Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/demux: stop calling avcodec_close()

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/demux: stop calling avcodec_close()

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1489 bytes --]

On Fri, Feb 09, 2024 at 03:19:58PM +0000, Anton Khirnov wrote:
> ffmpeg | branch: master | Anton Khirnov <anton@khirnov.net> | Thu Feb  1 08:57:24 2024 +0100| [ca18bb597223b3df5bbf8a1836d157ba58b62570] | committer: Anton Khirnov
> 
> lavf/demux: stop calling avcodec_close()
> 
> Replace it with recreating the codec context.
> 
> This is the last remaining blocker for deprecating avcodec_close().
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ca18bb597223b3df5bbf8a1836d157ba58b62570
> ---
> 
>  libavformat/demux.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 56 insertions(+), 5 deletions(-)

This breaks ffprobe "Closed Caption" output
before:
Stream #0:2[0x1e0]: Video: mpeg2video (Main), yuv420p(tv, progressive), 1920x1080 [SAR 1:1 DAR 16:9], Closed Captions, 29.97 fps, 59.94 tbr, 90k tbn

after:
Stream #0:2[0x1e0]: Video: mpeg2video (Main), yuv420p(tv, progressive), 1920x1080 [SAR 1:1 DAR 16:9], 29.97 fps, 59.94 tbr, 90k tbn

testcase:
./ffprobe ~/tickets/2147/sample.mpg 2>&1 | grep Stream

thx

should i open a ticket for this ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/demux: stop calling avcodec_close()

[Kieran Kunhya]

On Wed, 27 Mar 2024 at 14:03, Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Fri, Feb 09, 2024 at 03:19:58PM +0000, Anton Khirnov wrote:
> > ffmpeg | branch: master | Anton Khirnov <anton@khirnov.net> | Thu Feb
> 1 08:57:24 2024 +0100| [ca18bb597223b3df5bbf8a1836d157ba58b62570] |
> committer: Anton Khirnov
> >
> > lavf/demux: stop calling avcodec_close()
> >
> > Replace it with recreating the codec context.
> >
> > This is the last remaining blocker for deprecating avcodec_close().
> >
> > >
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ca18bb597223b3df5bbf8a1836d157ba58b62570
> > ---
> >
> >  libavformat/demux.c | 61
> ++++++++++++++++++++++++++++++++++++++++++++++++-----
> >  1 file changed, 56 insertions(+), 5 deletions(-)
>
> This breaks ffprobe "Closed Caption" output
> before:
> Stream #0:2[0x1e0]: Video: mpeg2video (Main), yuv420p(tv, progressive),
> 1920x1080 [SAR 1:1 DAR 16:9], Closed Captions, 29.97 fps, 59.94 tbr, 90k tbn
>

Closed Captions are sparse side data, we shouldn't be exposing it like this
to begin with.

Kieran
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/demux: stop calling avcodec_close()

[James Almer]

On 3/27/2024 11:13 AM, Kieran Kunhya wrote:
> On Wed, 27 Mar 2024 at 14:03, Michael Niedermayer <michael@niedermayer.cc>
> wrote:
> 
>> On Fri, Feb 09, 2024 at 03:19:58PM +0000, Anton Khirnov wrote:
>>> ffmpeg | branch: master | Anton Khirnov <anton@khirnov.net> | Thu Feb
>> 1 08:57:24 2024 +0100| [ca18bb597223b3df5bbf8a1836d157ba58b62570] |
>> committer: Anton Khirnov
>>>
>>> lavf/demux: stop calling avcodec_close()
>>>
>>> Replace it with recreating the codec context.
>>>
>>> This is the last remaining blocker for deprecating avcodec_close().
>>>
>>>>
>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ca18bb597223b3df5bbf8a1836d157ba58b62570
>>> ---
>>>
>>>   libavformat/demux.c | 61
>> ++++++++++++++++++++++++++++++++++++++++++++++++-----
>>>   1 file changed, 56 insertions(+), 5 deletions(-)
>>
>> This breaks ffprobe "Closed Caption" output
>> before:
>> Stream #0:2[0x1e0]: Video: mpeg2video (Main), yuv420p(tv, progressive),
>> 1920x1080 [SAR 1:1 DAR 16:9], Closed Captions, 29.97 fps, 59.94 tbr, 90k tbn
>>
> 
> Closed Captions are sparse side data, we shouldn't be exposing it like this
> to begin with.

This avcodec_string() output is based on which 
AVCodecContext->properties flags are set (For CC, it happens when a 
caption is found). Which yes, it's not exactly ideal.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/demux: stop calling avcodec_close()

[Anton Khirnov]

Quoting Kieran Kunhya (2024-03-27 15:13:12)
> On Wed, 27 Mar 2024 at 14:03, Michael Niedermayer <michael@niedermayer.cc>
> wrote:
> 
> > On Fri, Feb 09, 2024 at 03:19:58PM +0000, Anton Khirnov wrote:
> > > ffmpeg | branch: master | Anton Khirnov <anton@khirnov.net> | Thu Feb
> > 1 08:57:24 2024 +0100| [ca18bb597223b3df5bbf8a1836d157ba58b62570] |
> > committer: Anton Khirnov
> > >
> > > lavf/demux: stop calling avcodec_close()
> > >
> > > Replace it with recreating the codec context.
> > >
> > > This is the last remaining blocker for deprecating avcodec_close().
> > >
> > > >
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ca18bb597223b3df5bbf8a1836d157ba58b62570
> > > ---
> > >
> > >  libavformat/demux.c | 61
> > ++++++++++++++++++++++++++++++++++++++++++++++++-----
> > >  1 file changed, 56 insertions(+), 5 deletions(-)
> >
> > This breaks ffprobe "Closed Caption" output
> > before:
> > Stream #0:2[0x1e0]: Video: mpeg2video (Main), yuv420p(tv, progressive),
> > 1920x1080 [SAR 1:1 DAR 16:9], Closed Captions, 29.97 fps, 59.94 tbr, 90k tbn
> >
> 
> Closed Captions are sparse side data, we shouldn't be exposing it like this
> to begin with.

+1

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".