From: Michael Niedermayer <michael@niedermayer.cc>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/demux: stop calling avcodec_close()
Date: Wed, 27 Mar 2024 15:03:11 +0100
Message-ID: <20240327140311.GC2460414@pb2> (raw)
In-Reply-To: <20240209151959.C7231411B5B@natalya.videolan.org>
[-- Attachment #1.1: Type: text/plain, Size: 1489 bytes --]
On Fri, Feb 09, 2024 at 03:19:58PM +0000, Anton Khirnov wrote:
> ffmpeg | branch: master | Anton Khirnov <anton@khirnov.net> | Thu Feb 1 08:57:24 2024 +0100| [ca18bb597223b3df5bbf8a1836d157ba58b62570] | committer: Anton Khirnov
>
> lavf/demux: stop calling avcodec_close()
>
> Replace it with recreating the codec context.
>
> This is the last remaining blocker for deprecating avcodec_close().
>
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ca18bb597223b3df5bbf8a1836d157ba58b62570
> ---
>
> libavformat/demux.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 56 insertions(+), 5 deletions(-)
This breaks ffprobe "Closed Caption" output
before:
Stream #0:2[0x1e0]: Video: mpeg2video (Main), yuv420p(tv, progressive), 1920x1080 [SAR 1:1 DAR 16:9], Closed Captions, 29.97 fps, 59.94 tbr, 90k tbn
after:
Stream #0:2[0x1e0]: Video: mpeg2video (Main), yuv420p(tv, progressive), 1920x1080 [SAR 1:1 DAR 16:9], 29.97 fps, 59.94 tbr, 90k tbn
testcase:
./ffprobe ~/tickets/2147/sample.mpg 2>&1 | grep Stream
thx
should i open a ticket for this ?
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next parent reply other threads:[~2024-03-27 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240209151959.C7231411B5B@natalya.videolan.org>
2024-03-27 14:03 ` Michael Niedermayer [this message]
2024-03-27 14:13 ` Kieran Kunhya
2024-03-27 14:30 ` James Almer
2024-03-28 8:02 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327140311.GC2460414@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git