[FFmpeg-devel] [PATCH] Remove struct named initializer from aac profile option.

[FFmpeg-devel] [PATCH] Remove struct named initializer from aac profile option.

[Muiz Yusuff]

From: Muiz <muiz.dev@gmail.com>

All fields of the stuct use unnamed struct initialization.
Also omit the field name for `AVOption::unit` to maintain consistency.
---
 libavcodec/profiles.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/profiles.h b/libavcodec/profiles.h
index ffc8710ef2..270430a48b 100644
--- a/libavcodec/profiles.h
+++ b/libavcodec/profiles.h
@@ -23,7 +23,7 @@
 #include "libavutil/opt.h"
 
 #define FF_AVCTX_PROFILE_OPTION(name, description, type, value) \
-    {name, description, 0, AV_OPT_TYPE_CONST, {.i64 = value }, INT_MIN, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM | AV_OPT_FLAG_## type ##_PARAM, .unit = "avctx.profile"},
+    {name, description, 0, AV_OPT_TYPE_CONST, {.i64 = value }, INT_MIN, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM | AV_OPT_FLAG_## type ##_PARAM, "avctx.profile"},
 
 #define FF_AAC_PROFILE_OPTS \
     FF_AVCTX_PROFILE_OPTION("aac_main",      NULL, AUDIO, AV_PROFILE_AAC_MAIN)\
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] Remove struct named initializer from aac profile option.

[Hendrik Leppkes]

On Tue, Mar 26, 2024 at 9:42 AM Muiz Yusuff <muiz.rpi@gmail.com> wrote:
>
> From: Muiz <muiz.dev@gmail.com>
>
> All fields of the stuct use unnamed struct initialization.
> Also omit the field name for `AVOption::unit` to maintain consistency.

"unit" intentionally uses designated initializers, so that adding new
fields before it is more robust and less prone to errors.

See 1e7d2007c3aca1cc1cd3b1ca409f4ded6c885f86

- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".