Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 04/10] avformat/timecode: use 64bit for intermediate for rounding in fps_from_frame_rate()
Date: Tue, 26 Mar 2024 01:11:45 +0100
Message-ID: <20240326001151.12083-4-michael@niedermayer.cc> (raw)
In-Reply-To: <20240326001151.12083-1-michael@niedermayer.cc>

Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4802790784303104
Fixes: signed integer overflow: 1768972133 + 968491058 cannot be represented in type 'int'

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavutil/timecode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavutil/timecode.c b/libavutil/timecode.c
index b93f05b4b82..bd879bd3cc0 100644
--- a/libavutil/timecode.c
+++ b/libavutil/timecode.c
@@ -210,7 +210,7 @@ static int fps_from_frame_rate(AVRational rate)
 {
     if (!rate.den || !rate.num)
         return -1;
-    return (rate.num + rate.den/2) / rate.den;
+    return (rate.num + rate.den/2LL) / rate.den;
 }
 
 int av_timecode_check_frame_rate(AVRational rate)
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-03-26  0:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26  0:11 [FFmpeg-devel] [PATCH 01/10] avformat/concatdec: Check user_duration sum Michael Niedermayer
2024-03-26  0:11 ` [FFmpeg-devel] [PATCH 02/10] avformat/jacosubdec: Use 64bit for abs Michael Niedermayer
2024-03-26  0:11 ` [FFmpeg-devel] [PATCH 03/10] avformat/mov: use 64bit for intermediate for rounding Michael Niedermayer
2024-03-26  0:11 ` Michael Niedermayer [this message]
2024-03-26  0:11 ` [FFmpeg-devel] [PATCH 05/10] avformat/rpl: Use 64bit for total_audio_size and check it Michael Niedermayer
2024-03-26  0:11 ` [FFmpeg-devel] [PATCH 06/10] avformat/sbgdec: Check for negative duration Michael Niedermayer
2024-03-26  0:11 ` [FFmpeg-devel] [PATCH 07/10] avformat/wavdec: sanity check channels and bps before using them for block_align Michael Niedermayer
2024-03-27  9:42   ` Anton Khirnov
2024-03-27 20:56     ` Michael Niedermayer
2024-03-26  0:11 ` [FFmpeg-devel] [PATCH 08/10] avformat/wavdec: satuarte next_tag_ofs, data_end Michael Niedermayer
2024-03-26  0:11 ` [FFmpeg-devel] [PATCH 09/10] avformat/matroskadec: Check timescale Michael Niedermayer
2024-03-26  0:11 ` [FFmpeg-devel] [PATCH 10/10] avformat/westwood_vqa: Fix 2g packets Michael Niedermayer
2024-03-26 19:19 ` [FFmpeg-devel] [PATCH 01/10] avformat/concatdec: Check user_duration sum Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240326001151.12083-4-michael@niedermayer.cc \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git