Re: [FFmpeg-devel] [PATCH 03/10] avutil/common: Don't auto-include mem.h

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1221 bytes --]

On Mon, Mar 25, 2024 at 02:53:17AM +0100, Andreas Rheinhardt wrote:
> There are lots of files that don't need it: The number of object
> files that actually need it went down from 2011 to 884 here.
> 
> Keep it for external users in order to not cause breakages.
> 
> Also improve the other headers a bit while just at it.

breaks mips build:

src/libavformat/asfdec_f.c: In function ‘asf_read_stream_properties’:
src/libavformat/asfdec_f.c:438:38: error: implicit declaration of function ‘av_bswap32’; did you mean ‘av_escape’? [-Werror=implicit-function-declaration]
                 asf_st->palette[i] = av_bswap32(((uint32_t *)st->codecpar->extradata)[i]);
                                      ^~~~~~~~~~
                                      av_escape
cc1: some warnings being treated as errors
src/ffbuild/common.mak:81: recipe for target 'libavformat/asfdec_f.o' failed
make: *** [libavformat/asfdec_f.o] Error 1
make: *** Waiting for unfinished jobs....

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".