From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0D49248A19 for ; Sun, 24 Mar 2024 00:11:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2032968D3CD; Sun, 24 Mar 2024 02:11:09 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 65BC568D39C for ; Sun, 24 Mar 2024 02:11:02 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 9944AC0003 for ; Sun, 24 Mar 2024 00:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1711239061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nMQLwMcZzWikgUchg0eYaoZCK65iWQKpfmX704lUuRs=; b=b9bmIhJ+Zq+r+d4YpUEsy2qie+z8dmQk0h5ksFdbHgh1cwA09tJXFZWf/VFNxRR7LxXilf KjVxUK7X9pr7FSjgtn8tVsGUHkSfMUK4An/YnhU9juiEUU3vmdGr+i1JeGNLRWEOhFk8Jp KT+JOQa1/+1VFGbDzLnG3ij3hIf+RXavI9NzMbd3wPgTkcu6LUf1zbKR3mltNZRu6VMk5W 4lNAyYQGQ+oI0jayey/5cuOANKHonl9VawjZsDWO+BQ/YvQPC7wI3TphFE8Ebh+31wqcWj 5MJpRv2XZDlh/jLeLLdM3x5S7ho3WvqqfbpNz1JOE2RtEsofDnpPbIfwYV6Bug== Date: Sun, 24 Mar 2024 01:11:00 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240324001100.GF6420@pb2> References: <20240322202841.31730-1-anton@khirnov.net> <20240322202841.31730-8-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20240322202841.31730-8-anton@khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 08/12] lavc/frame_thread_encoder: avoid assigning a whole AVCodecContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2127329189552464477==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2127329189552464477== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yhCCA/nfbalMTVDP" Content-Disposition: inline --yhCCA/nfbalMTVDP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 22, 2024 at 09:28:37PM +0100, Anton Khirnov wrote: > It is highly unsafe, as AVCodecContext contains many allocated fields. > Copying information via AVCodecParameters and with av_opt_copy() should > handle everything needed by thread workers. > --- > libavcodec/frame_thread_encoder.c | 26 ++++++++++++++++++++------ > 1 file changed, 20 insertions(+), 6 deletions(-) this breaks huffyuv with 2 pass [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle --yhCCA/nfbalMTVDP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZf9vjgAKCRBhHseHBAsP qyUqAJ0bx/xeRbFkL6H9cJLhsMegHxSM2QCeOVHEKwRGq/4gNLNSoWAD79FiNJo= =kn/Y -----END PGP SIGNATURE----- --yhCCA/nfbalMTVDP-- --===============2127329189552464477== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2127329189552464477==--