From: Leo Izen <leo.izen@gmail.com> To: ffmpeg-devel@ffmpeg.org Cc: Leo Izen <leo.izen@gmail.com> Subject: [FFmpeg-devel] [PATCH 2/2] avutil/film_grain_params: remove do loop in CHECK macro Date: Sat, 23 Mar 2024 20:10:14 -0400 Message-ID: <20240324001014.55461-3-leo.izen@gmail.com> (raw) In-Reply-To: <20240324001014.55461-1-leo.izen@gmail.com> The continue statement will break out of the do/while loop, not the outer loop as intended. This is one (compound) statement anyway, so we can remove the do/while entirely. Signed-off-by: Leo Izen <leo.izen@gmail.com> --- libavutil/film_grain_params.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavutil/film_grain_params.c b/libavutil/film_grain_params.c index b3fa37f527..8f8dcee569 100644 --- a/libavutil/film_grain_params.c +++ b/libavutil/film_grain_params.c @@ -70,10 +70,8 @@ const AVFilmGrainParams *av_film_grain_params_select(const AVFrame *frame) continue; #define CHECK(a, b, unspec) \ - do { \ if ((a) != (unspec) && (b) != (unspec) && (a) != (b)) \ - continue; \ - } while (0) + continue CHECK(fgp->bit_depth_luma, bit_depth_luma, 0); CHECK(fgp->bit_depth_chroma, bit_depth_chroma, 0); -- 2.44.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-03-24 0:10 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-24 0:10 [FFmpeg-devel] [PATCH 0/2] Minor avutil/film_grain_params tweaks Leo Izen 2024-03-24 0:10 ` [FFmpeg-devel] [PATCH 1/2] avutil/film_grain_params: remove unused variables Leo Izen 2024-03-24 0:10 ` Leo Izen [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240324001014.55461-3-leo.izen@gmail.com \ --to=leo.izen@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git