From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C8A604A1BE for ; Sat, 23 Mar 2024 17:50:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C48BA68D3BA; Sat, 23 Mar 2024 19:50:50 +0200 (EET) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9DF9068D384 for ; Sat, 23 Mar 2024 19:50:44 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1711216244; bh=YNOvJp2bU6QXzii4V8bZiPaOBHu9AoQN8U3bA/Lc1QQ=; h=Date:From:To:Subject:In-Reply-To:References:From; b=GeqS2hFPBsY7OkSG1aa+p7T8sVglGJuSp+bE+e+dWcwm8KkQ7SPprudhr6HON/+OY GWdikRve/H3JH8juupzfCW7AHVu55hK7AO9ndN/+p88xjxAFOzaCdVlxawR55wU4GL K7tgEEW2mggb1EKCUirFHEitG80h8EgiGIF6kksU= Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id 6751A40015 for ; Sat, 23 Mar 2024 18:50:44 +0100 (CET) Date: Sat, 23 Mar 2024 18:50:44 +0100 Message-ID: <20240323185044.GD28382@haasn.xyz> From: Niklas Haas To: FFmpeg development discussions and patches In-Reply-To: <20240320195526.GV6420@pb2> References: <20240313122425.92457-1-ffmpeg@haasn.xyz> <20240313122425.92457-2-ffmpeg@haasn.xyz> <20240319215556.GO6420@pb2> <20240320152353.GB35343@haasn.xyz> <20240320195526.GV6420@pb2> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale2ref: switch to FFFrameSync X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 20 Mar 2024 20:55:26 +0100 Michael Niedermayer wrote: > On Wed, Mar 20, 2024 at 03:23:53PM +0100, Niklas Haas wrote: > > On Tue, 19 Mar 2024 22:55:56 +0100 Michael Niedermayer wrote: > > > is it neccessary to drop compatibility to the old syntax ? > > > > Only if we want to use framesync. If we don't care about synchronizing > > the streams, then we could drop FS and just use a custom activate > > function which forwards output status only to the *corresponding* input. > > if the full bugfix cant be done in the same filter then i guess we need a 2nd > filter, maybe scale1ref I think we can do this by extending vf_scale itself to support taking a second input, that way we don't need a second filter at all. My proposal for this: - Add new variables ref_w, ref_h (and related fields), possibly aliased to 'rw' and 'rh'. - When `ref_*` is referenced in any expression, vf_scale will init() with a second input stream. - Semantics will be equivalent to this patch. - Fully deprecate scale2ref, and eventually remove it and the main_* series of variables. That way, scale2ref just becomes `scale=w=rw:h=rh`, and also allows us to simplify these filters a bit. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".