From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6F4ED4A15B for ; Fri, 22 Mar 2024 20:58:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0563068D55D; Fri, 22 Mar 2024 22:58:11 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5562C68D46E for ; Fri, 22 Mar 2024 22:58:04 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 718B820002 for ; Fri, 22 Mar 2024 20:58:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1711141083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jNbKtuPM1MA17SinQcTmuuAn+8PnmettD9GytHTPiQE=; b=dB7u87NyjihLJ57MbKQoZOedarCFfcLbps2wdzHVRSKag1I8CUuftiY3yDx8F8cGxfaWrU hP4EOCblu76sScHDg3QQVdv7OOvvofaqwfkj0HqMn1BVG0EpjGbRYhI8Fb/E4/VJw8eLrV GrZQRIoAl3mXAFZTFXjqvqx3eHVnr/lVNmCAbDmjdpwzzfc4OjQfn2RbqF33axLBFBo9nJ GFBbypy/4WVGTAXU3bXacH+yDmCkHBXIkjpR7+OmmqlPKgMX1KeZ8QiB3HJnZo45NV8NDN 52vPyOryUszWznnuUY0/B+i6031rAefjlKcQoohTQtJNrrPVqzGppiWA8DI5Zg== Date: Fri, 22 Mar 2024 21:58:02 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240322205802.GD6420@pb2> References: <20240322022525.GB6420@pb2> <139bd591-67d2-407e-a90e-fe34ff3c576d@gmail.com> MIME-Version: 1.0 In-Reply-To: <139bd591-67d2-407e-a90e-fe34ff3c576d@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [RFC] Channels X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6790291557454621040==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6790291557454621040== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fNJhN8t0vlFArBk8" Content-Disposition: inline --fNJhN8t0vlFArBk8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 21, 2024 at 11:59:17PM -0300, James Almer wrote: > On 3/21/2024 11:25 PM, Michael Niedermayer wrote: > > Hi all > >=20 > > we have code like > > st->codecpar->ch_layout.nb_channels =3D avio_rb32(pb); > >=20 > > and then somewhere there is some code that uses this by first allocating > > an array and that then hits OOM > > (it was this here: > > map =3D av_calloc(nb_channels, sizeof(*channel_layout->u.map));) > >=20 > > is anyone against adding a max_channels field to AVFormatContext or so= mething > > like that ? > >=20 > > alternative is "wont fix" for all such cases, or maybe someone sees ano= ther way ? > >=20 > > thx >=20 > We have FF_SANE_NB_CHANNELS, so maybe add a check for it to mxfdec.c (Whe= re > i assume this is happening) and mov_chan.c or mov.c before continuing with > such a layout. wasnt mxf, ill send a patch thanks! [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the death your right to say it. -- Voltaire --fNJhN8t0vlFArBk8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZf3w1AAKCRBhHseHBAsP q8hzAJ9Hl8eNB3izrb5FXxpKVIsP5eDMQgCfTpDhSrbbONA+hEqLFi3DYxk5ZZc= =CTNr -----END PGP SIGNATURE----- --fNJhN8t0vlFArBk8-- --===============6790291557454621040== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6790291557454621040==--