Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] sizeof(HEVCVPS)
@ 2024-03-20 22:23 Michael Niedermayer
  2024-03-20 23:09 ` Lynne
  2024-03-21  0:31 ` James Almer
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Niedermayer @ 2024-03-20 22:23 UTC (permalink / raw)
  To: FFmpeg development discussions and patches


[-- Attachment #1.1: Type: text/plain, Size: 719 bytes --]

Hi

why is sizeof(HEVCVPS) is 7463476 ?

If you think about this for a moment, a VPS in the bit stream is what, 5 bytes ?

Now iam not even talking about someone proving you a 10mb file with a million VPSs
7TB allocation, memsets memcpies, ...

But even with a totally normal file 7mb is easily bigger than the frame buffer
that wastes memory, it wastes cpu time, it wastes data cache

thx

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [FFmpeg-devel] sizeof(HEVCVPS)
  2024-03-20 22:23 [FFmpeg-devel] sizeof(HEVCVPS) Michael Niedermayer
@ 2024-03-20 23:09 ` Lynne
  2024-03-21  0:31 ` James Almer
  1 sibling, 0 replies; 3+ messages in thread
From: Lynne @ 2024-03-20 23:09 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

Mar 20, 2024, 23:24 by michael@niedermayer.cc:

> Hi
>
> why is sizeof(HEVCVPS) is 7463476 ?
>
> If you think about this for a moment, a VPS in the bit stream is what, 5 bytes ?
>
> Now iam not even talking about someone proving you a 10mb file with a million VPSs
> 7TB allocation, memsets memcpies, ...
>
> But even with a totally normal file 7mb is easily bigger than the frame buffer
> that wastes memory, it wastes cpu time, it wastes data cache
>

As discussed on IRC, Vulkan ran into this.
The size of all HEVC structs (SPS, VPS, PPS) at their maximum array sizes is ~120 Mb.
That's why there's a function in Vulkan to allocate them on demand.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [FFmpeg-devel] sizeof(HEVCVPS)
  2024-03-20 22:23 [FFmpeg-devel] sizeof(HEVCVPS) Michael Niedermayer
  2024-03-20 23:09 ` Lynne
@ 2024-03-21  0:31 ` James Almer
  1 sibling, 0 replies; 3+ messages in thread
From: James Almer @ 2024-03-21  0:31 UTC (permalink / raw)
  To: ffmpeg-devel

On 3/20/2024 7:23 PM, Michael Niedermayer wrote:
> Hi
> 
> why is sizeof(HEVCVPS) is 7463476 ?
> 
> If you think about this for a moment, a VPS in the bit stream is what, 5 bytes ?
> 
> Now iam not even talking about someone proving you a 10mb file with a million VPSs
> 7TB allocation, memsets memcpies, ...
> 
> But even with a totally normal file 7mb is easily bigger than the frame buffer
> that wastes memory, it wastes cpu time, it wastes data cache
> 
> thx

Posted a patch for this.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-21  0:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-20 22:23 [FFmpeg-devel] sizeof(HEVCVPS) Michael Niedermayer
2024-03-20 23:09 ` Lynne
2024-03-21  0:31 ` James Almer

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git