From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9586C497C6 for ; Wed, 20 Mar 2024 19:51:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ED09768D4E0; Wed, 20 Mar 2024 21:51:53 +0200 (EET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 42D1868D464 for ; Wed, 20 Mar 2024 21:51:48 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 72FE31BF206 for ; Wed, 20 Mar 2024 19:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1710964307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mkemzX81wL19vTComBSE0PmkhuzS6P8gG/s72dsB1ig=; b=k35tGund+VgYjm+Hsf3ZEJzYo8wraV1AqDlxlZtvVo9LahGoznnchTGDrkJY6LV1w7g3b9 U6JFtz4+TxNea60tOFdnWjf63ifiHzB6FelU3+BJizUAQeKWVaKR2kCLfPRjc/pKArBD6J d7mdDXJVd66L21m6reBD3Rgwuf+mtklSVMWBuB7k+m0fv8WJbH/wkYxO3swbyn1+fMcZ3a dLS092Zy5MkOCmQ5loVvPVVUZS8MDyrxYKpzuwMfFvI63Km2zTpDyTFgTBkWewFS0sajp+ Zr7X/wZUinQ6v+PNlX0hjxLdMgnvZ7eTl3lwBVNW916jCOwOVCMN9JHE8LuPmw== Date: Wed, 20 Mar 2024 20:51:46 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240320195146.GU6420@pb2> References: <20240320021926.3759-1-michael@niedermayer.cc> <20240320021926.3759-3-michael@niedermayer.cc> <20240320130201.GQ6420@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 3/3] Revert "avcodec/h264_mp4toannexb_bsf: fix missing PS before IDR frames" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5865949019842715550==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5865949019842715550== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4uFq+lUU9KcQ+MQW" Content-Disposition: inline --4uFq+lUU9KcQ+MQW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 21, 2024 at 01:53:12AM +0800, Zhao Zhili wrote: >=20 >=20 > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of Micha= el Niedermayer > > Sent: 2024=E5=B9=B43=E6=9C=8820=E6=97=A5 21:02 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 3/3] Revert "avcodec/h264_mp4toannex= b_bsf: fix missing PS before IDR frames" > >=20 > > On Wed, Mar 20, 2024 at 02:41:05PM +0800, Zhao Zhili wrote: > > > > > > > > > > On Mar 20, 2024, at 10:19, Michael Niedermayer wrote: > > > > > > > > This reverts commit d3aa0cd16f5e952bc346b7c74b4dcba95151a63a. > > > > > > > > Fixes: out of array write > > > > Fixes: 64407/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_MP4TOAN= NEXB_fuzzer-4966763443650560 > > > > > > > > The bsf code performs 2 iterations, the first counts how much space= is needed > > > > than allocates > > > > and the 2nd pass copies into teh allocated space > > > > > > > > The reverted code reallocates sps/pps in the first pass in a data d= ependant way that leaves > > > > the 2nd pass in a different state then the first > > > > > > Sorry for the break. How to access the fuzz report details? > >=20 > > ossfuzz made this one public already > > https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3D64407 >=20 > I can't open the "Detailed Report" link. Does it provide asan details? yes, posted them to you privately, i didnt realize that wasnt public while = the testcase is thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everything ms did were stupid they would be bankrupt already. --4uFq+lUU9KcQ+MQW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZfs+UQAKCRBhHseHBAsP qzTgAJ947DTp8XO5Sfe2t+2XQDWOe5SEsACfYhMToi8cVFKdvupIEMUeUYhJwzU= =jr5R -----END PGP SIGNATURE----- --4uFq+lUU9KcQ+MQW-- --===============5865949019842715550== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5865949019842715550==--