From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] Revert "avcodec/h264_mp4toannexb_bsf: fix missing PS before IDR frames"
Date: Wed, 20 Mar 2024 14:02:01 +0100
Message-ID: <20240320130201.GQ6420@pb2> (raw)
In-Reply-To: <tencent_1A45597300E85DF3E7336055C109086EA505@qq.com>
[-- Attachment #1.1: Type: text/plain, Size: 1313 bytes --]
On Wed, Mar 20, 2024 at 02:41:05PM +0800, Zhao Zhili wrote:
>
>
> > On Mar 20, 2024, at 10:19, Michael Niedermayer <michael@niedermayer.cc> wrote:
> >
> > This reverts commit d3aa0cd16f5e952bc346b7c74b4dcba95151a63a.
> >
> > Fixes: out of array write
> > Fixes: 64407/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_MP4TOANNEXB_fuzzer-4966763443650560
> >
> > The bsf code performs 2 iterations, the first counts how much space is needed
> > than allocates
> > and the 2nd pass copies into teh allocated space
> >
> > The reverted code reallocates sps/pps in the first pass in a data dependant way that leaves
> > the 2nd pass in a different state then the first
>
> Sorry for the break. How to access the fuzz report details?
ossfuzz made this one public already
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=64407
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Modern terrorism, a quick summary: Need oil, start war with country that
has oil, kill hundread thousand in war. Let country fall into chaos,
be surprised about raise of fundamantalists. Drop more bombs, kill more
people, be surprised about them taking revenge and drop even more bombs
and strip your own citizens of their rights and freedoms. to be continued
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-20 13:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 2:19 [FFmpeg-devel] [PATCH 1/3] avformat/wady: Check >0 samplerate and channels 1 || 2 Michael Niedermayer
2024-03-20 2:19 ` [FFmpeg-devel] [PATCH 2/3] avformat/mov: Check sample_count and auxiliary_info_default_size to be 0 Michael Niedermayer
2024-03-20 2:19 ` [FFmpeg-devel] [PATCH 3/3] Revert "avcodec/h264_mp4toannexb_bsf: fix missing PS before IDR frames" Michael Niedermayer
2024-03-20 6:41 ` Zhao Zhili
2024-03-20 13:02 ` Michael Niedermayer [this message]
2024-03-20 17:53 ` Zhao Zhili
2024-03-20 19:51 ` Michael Niedermayer
2024-03-25 17:17 ` [FFmpeg-devel] [PATCH 1/3] avformat/wady: Check >0 samplerate and channels 1 || 2 Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320130201.GQ6420@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git