From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C519F4A0A3 for ; Tue, 19 Mar 2024 21:56:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8942368D3FC; Tue, 19 Mar 2024 23:56:06 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E271568D367 for ; Tue, 19 Mar 2024 23:55:59 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 084EC60003 for ; Tue, 19 Mar 2024 21:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1710885359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZC6GGYw3T87jIHPPA7wdbIxqJNQu32gl/jJWlERjz3c=; b=UpnjYa39tjbtNZKOMgs20yspZrvCMoGa1WokjlIkSHuPJSYirt2bT7iiBP4Y54UFX4QJMR 5GyqcSxWJmgwkJd69TrkGClNilwj4da+VwaIXhJGRGiYhoF4fV72VmszQueeZ5vSJXAFFY 8JRwIMNQCpwXOzEOGHbEKjA/P4IMctxSUQ9UiNWqbditbqu5M0mAcJZNTnY6dS4HjD2g9E z52EYrBMT1v7dJqJfXghSrzdHaVphYJbgeEQEZVNKDKj5hd1Sr1juTu4EFxfxC2vOvc3x+ zxmmvYfe6lTdt/72s+IsRNASGXcuxnQJ6/lpdd0oaiIwA636nUz/WV2x1z/aug== Date: Tue, 19 Mar 2024 22:55:56 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240319215556.GO6420@pb2> References: <20240313122425.92457-1-ffmpeg@haasn.xyz> <20240313122425.92457-2-ffmpeg@haasn.xyz> MIME-Version: 1.0 In-Reply-To: <20240313122425.92457-2-ffmpeg@haasn.xyz> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale2ref: switch to FFFrameSync X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6422222713616274567==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6422222713616274567== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cFn2WG1tOG6vF5LC" Content-Disposition: inline --cFn2WG1tOG6vF5LC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 13, 2024 at 01:24:25PM +0100, Niklas Haas wrote: > From: Niklas Haas >=20 > This filter's existing design has a number of issues: >=20 > - There is no guarantee whatsoever about the order in which frames are > pushed onto the main and ref link, due to this being entirely > dependent on the order in which downstream filters decide to request > frames from their various inputs. As such, there is absolutely no > synchronization for ref streams with dynamically changing resolutions > (see e.g. fate/h264/reinit-*). >=20 > - For some (likely historical) reason, this filter outputs its ref > stream as a second ref output, which is in principle completely > unnecessary (complex filter graph users can just duplicate the input > pin), but in practice only required to allow this filter to > "eventually" see changes to the ref stream (see first point). In > particular, this means that if the user uses the "wrong" pin, this > filter may break completely. >=20 > - The default filter activation function is fundamentally incapable of > handling filters with multiple inputs cleanly, because doing so > requires both knowledge of how these inputs should be internally > ordered, but also how to handle EOF conditions on either input (or > downstream). Both of these are best left to the filter specific > options. (See #10795 for the consequences of using the default > activate with multiple inputs). >=20 > Switching this filter to framesync fixes all three points: >=20 > - ff_framesync_activate() correctly handles multiple inputs and EOF > conditions (and is configurable with the framesync-specific options) > - framesync only supports a single output, so we can (indeed must) drop > the redundant ref output stream >=20 > Update documentation, changelog and tests to correspond to the new usage > pattern. >=20 > Fixes: https://trac.ffmpeg.org/ticket/10795 > --- > Changelog | 2 + > doc/filters.texi | 10 +- > libavfilter/vf_scale.c | 130 ++++++++++++----------- > tests/filtergraphs/scale2ref_keep_aspect | 3 +- > 4 files changed, 76 insertions(+), 69 deletions(-) >=20 > diff --git a/Changelog b/Changelog > index 069b8274489..bacda2524ea 100644 > --- a/Changelog > +++ b/Changelog > @@ -32,6 +32,8 @@ version : > - DVD-Video demuxer, powered by libdvdnav and libdvdread > - ffprobe -show_stream_groups option > - ffprobe (with -export_side_data film_grain) now prints film grain meta= data > +- scale2ref now only has a single output stream, and supports the frames= ync > + options is it neccessary to drop compatibility to the old syntax ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you drop bombs on a foreign country and kill a hundred thousand innocent people, expect your government to call the consequence "unprovoked inhuman terrorist attacks" and use it to justify dropping more bombs and killing more people. The technology changed, the idea is old. --cFn2WG1tOG6vF5LC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZfoJ5gAKCRBhHseHBAsP q7gCAJ9ihATekg7dJxfk6OxAbNi7STCFUwCcCQD2p9VjrnoGjNxe5jRJaV3Crno= =BE8R -----END PGP SIGNATURE----- --cFn2WG1tOG6vF5LC-- --===============6422222713616274567== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6422222713616274567==--