From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B41174A0A0 for ; Tue, 19 Mar 2024 21:41:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7CC0E68D44D; Tue, 19 Mar 2024 23:41:26 +0200 (EET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7C9CA68C409 for ; Tue, 19 Mar 2024 23:41:20 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id CE7B6E0002 for ; Tue, 19 Mar 2024 21:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1710884480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KAzChxtZ7OA+dIszhEZR4fF+CrxIyiAk3U2X3MdUOzM=; b=YrhJqoFnVQHwyFj3ZfjwboQHy1+Y6ogEQSdOlty8aGQF0Qp17kksCg/yuUulYdeFBhmzm2 x6BArcz03CqhpTPZwFH5h9u4CORftD8CAzFWmofhXk0C4lPvTlDEmc22di17Aj51VYzLmd xCoDqinOO2+Z4caN7BWy+ccOwq6ZjjhFkjQmdoAox4Mc+YXBT3rXjVdsQZRpzFtkoJ1HSN uvqJZCyeZF4/D7+6HKByBNAzugu3F2W6uAC8hsi7ZQwBYExRqZ+ldnRRHIB8Kpt809w/1W +TTOjHy7YGhJ8cq/zwtl/qWLFaO2i7CRY2DBGL75fG3+bjNhcIqRKI0xZmMScw== Date: Tue, 19 Mar 2024 22:41:19 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240319214119.GN6420@pb2> References: <20240319173913.2754690-1-marth64@proxyid.net> MIME-Version: 1.0 In-Reply-To: <20240319173913.2754690-1-marth64@proxyid.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v5 1/4] avformat/rcwtdec: add RCWT Closed Captions demuxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8012622685187950100==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8012622685187950100== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fXL5ECs6Aq/kOBul" Content-Disposition: inline --fXL5ECs6Aq/kOBul Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 19, 2024 at 12:39:10PM -0500, Marth64 wrote: > Signed-off-by: Marth64 > --- > Changelog | 2 +- > doc/demuxers.texi | 29 ++++++++ > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/rcwtdec.c | 148 +++++++++++++++++++++++++++++++++++++++ > 5 files changed, 180 insertions(+), 1 deletion(-) > create mode 100644 libavformat/rcwtdec.c [...] > +static int rcwt_probe(const AVProbeData *p) > +{ > + return p->buf_size > RCWT_HEADER_SIZE && > + AV_RB16(p->buf) =3D=3D 0xCCCC && AV_RB8(p->buf + 2) =3D=3D 0x= ED ? 50 : 0; > +} this fails tools/probetest 256 4096 Failure of rcwt probing code with score=3D50 type=3D2 p=3DF01 size=3D16 can you make the test more robust ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle --fXL5ECs6Aq/kOBul Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZfoGfwAKCRBhHseHBAsP qzFLAJkBDdRiUNTI9Y30ZoiP0LVXqiLd+QCfZlshx1VnLmfAdSe3aNmpVSDdtwo= =9iP/ -----END PGP SIGNATURE----- --fXL5ECs6Aq/kOBul-- --===============8012622685187950100== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8012622685187950100==--