From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9C11A496A1 for ; Tue, 19 Mar 2024 01:24:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ACE8B68D3A4; Tue, 19 Mar 2024 03:24:04 +0200 (EET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F3B1368D316 for ; Tue, 19 Mar 2024 03:23:57 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id D8B3DE0002 for ; Tue, 19 Mar 2024 01:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1710811437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WbjEhVrlxymAeSG+M8PnfiQw8S8E4niK/+DqESS6n14=; b=KMJGIo6bqCadbyAxY3td3ScfpMloiKJBmoOp0ii4w4S5mrtxAG3DtArkbhopwg1fcBVA+I 70lgREvoCMoKy4cRvR0ksNTRuYBbKIXXY9RJAgPWx4w5KsltCQtXAzPfKyaBQyOx6MKLqb zQOw7WKvqxSlZIquytgZHCNrQrX6DyZ/9JzHjQ3aTAN1HSB4zIDHhUUqeoP3apE3TM3fI+ RyzfXB6T8TNoS8YkmWjHl9OzA7rrt/m7cj9RNQveRRMXbPT8iHX8VftH90Ctp51Z3BLDti 3N2zmqYHjC8D1UzI9tdnQQaqO1594Qi8CfJd7NLOTKN0urbCHXLMrlQrO/ju8A== Date: Tue, 19 Mar 2024 02:23:56 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240319012356.GJ6420@pb2> References: <20240314211352.GB6420@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat: enable UDP IPv6 multicast interface selection X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8482011223958256279==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8482011223958256279== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6Wa8G1rWxidEd8yU" Content-Disposition: inline --6Wa8G1rWxidEd8yU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Mon, Mar 18, 2024 at 01:45:00PM +0000, Ignjatovi=C4=87, Lazar (RS)=EF=BF= =BD wrote: >=20 > This message has been marked as Public on 03/18/2024 13:45Z. > On Thursday, March 14, 2024 10:14 PM, Michael Niedermayer wrote: >=20 > > breaks mingw64 build > > > > CC libavformat/ip.o > > src/libavformat/ip.c: In function =E2=80=98ff_ip_resolve_interface_inde= x=E2=80=99: > > src/libavformat/ip.c:206:1: error: control reaches end of non-void func= tion [-Werror=3Dreturn-type] } ^ > > cc1: some warnings being treated as errors > > src/ffbuild/common.mak:81: recipe for target 'libavformat/ip.o' failed > > make: *** [libavformat/ip.o] Error 1 >=20 > I see the problem, when building for windows without iphlpapi.h, mentione= d function has no code within. > Will account for such case. >=20 > > also configure produces > > ../configure: 6415: ../configure: network_extralibs+=3D -liphlpapi: not= found >=20 > Problem here is that "+=3D" operator is a bashism, probably causing the p= revious error by not including iphlpapi properly. >=20 > Some questions I have: > Should I send another patch within this thread to address these comments,= or should I create a V2 of the patch? > Also, if creating a V2, should the patch be sent within this thread, or s= hould a new thread be opened? new patch with "V2" it can be sent in the same or a new thread, developers are not consistent w= ith that. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB There will always be a question for which you do not know the correct answe= r. --6Wa8G1rWxidEd8yU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZfjpIgAKCRBhHseHBAsP q5w2AJwJwRnmeXhfBSEFW4sDgqAxylfc3QCeIdSWS+uf2yf4OlVP3M1+31tmS7s= =0X25 -----END PGP SIGNATURE----- --6Wa8G1rWxidEd8yU-- --===============8482011223958256279== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8482011223958256279==--