From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D70AE496B9 for ; Tue, 19 Mar 2024 00:16:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 85D6F68D3A0; Tue, 19 Mar 2024 02:16:03 +0200 (EET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 40E7568D245 for ; Tue, 19 Mar 2024 02:15:57 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 51E691BF206 for ; Tue, 19 Mar 2024 00:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1710807355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AO3l9vn5yEE5EGGjxottUUKpMRM/oDQ2U7hE7M0rT7M=; b=Uh4VqAjh4EJMGsjsBGzvkFZAY0yJsnzCZ30HiMSN1K3iE5KQ3vmLyr05Jl6f4DnAg9MF6K fckMOjEk4MUzm530Ik53hNKfLzRbyCW36NPmAxtk1tVt0Mz1uyXLTHxwqD8p+gljBcFtmS k0XRx5UQWqD15z4pbHR53YdtknTOaAzWLzjsos9Z6zsM40hsmuyMglYsCKbiq+SGcIY9E+ CD64SLdhNf3md8lw+hKPdo42e2CeA2yTi9p3Xym7RfyD/ssf+pd7HBjSJDB0dI0OWzwNc2 jXswgpQslDC8FpZ3D9Yi7uXEnsCKK4meDEgCwUEj90nynLJEAVmYwcNRMUmj0Q== Date: Tue, 19 Mar 2024 01:15:54 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240319001554.GI6420@pb2> References: <20240317195729.11755-1-cus@passwd.hu> <20240317195729.11755-2-cus@passwd.hu> MIME-Version: 1.0 In-Reply-To: <20240317195729.11755-2-cus@passwd.hu> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/riffdec: follow the MS docs more strictly for setting wav channel layouts X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8918233068638455527==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8918233068638455527== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1dYwBknD4CTkTzUl" Content-Disposition: inline --1dYwBknD4CTkTzUl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 17, 2024 at 08:57:29PM +0100, Marton Balint wrote: > - Only parse the defined masks in dwChannelMask, unless strict_std_compli= ance > is less than normal. This matches with the behaviour of the wav muxer. > - Ignore additional bits in dwChannelMasks as the MS documentation sugges= ts [1] > - Assume UNKNOWN channels for missing bits as the MS documentation sugges= ts [1] >=20 > [1] https://learn.microsoft.com/en-us/previous-versions/windows/hardware/= design/dn653308(v=3Dvs.85)#details-about-dwchannelmask >=20 > Signed-off-by: Marton Balint > --- > libavformat/riffdec.c | 28 +++++++++++++++++++++++++--- > 1 file changed, 25 insertions(+), 3 deletions(-) breaks: =2E/ffmpeg -i ~/tickets/2859/5.1plusdownmix.wav -ac 2 -t 100 -bitexact -c:= a aac -y /tmp/2859-frenchspeack-nolibfaac.mp4 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB There will always be a question for which you do not know the correct answe= r. --1dYwBknD4CTkTzUl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZfjZNwAKCRBhHseHBAsP q7FhAJ0Tu1KInYQyDt6dO+g+zIQdlXVUqgCeLEo+7PePIfv5Ap7XzFS33sIdeMs= =bcv8 -----END PGP SIGNATURE----- --1dYwBknD4CTkTzUl-- --===============8918233068638455527== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8918233068638455527==--