From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 1FEBC49F75
	for <ffmpegdev@gitmailbox.com>; Fri, 15 Mar 2024 12:23:55 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 067A668D15D;
	Fri, 15 Mar 2024 14:23:54 +0200 (EET)
Received: from haasn.dev (haasn.dev [78.46.187.166])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4C96668D04F
 for <ffmpeg-devel@ffmpeg.org>; Fri, 15 Mar 2024 14:23:48 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail;
 t=1710505428; bh=zeuvbSNxhN/kFyzXnXmc+c1/n5PsIx1+BAL1hABZDPU=;
 h=Date:From:To:Subject:In-Reply-To:References:From;
 b=Cfn5/onsT9Dd+xgkALAdIP31k4SePwOV8m/uG3svp/U/e1k0qWretaoW1OysFGy/V
 m7sM+W92GYDiJTtd3qVK2AfdXzJuPd5eO0Jvq7e8RDjfZmBcW72qq5qbe46qkonOdZ
 Z5dMhmH4FOaCrIWQFLHmSWkjABPX21xVrTujEv6I=
Received: from haasn.dev (unknown [10.30.0.2])
 by haasn.dev (Postfix) with ESMTP id 194EB40247
 for <ffmpeg-devel@ffmpeg.org>; Fri, 15 Mar 2024 13:23:48 +0100 (CET)
Date: Fri, 15 Mar 2024 13:23:47 +0100
Message-ID: <20240315132347.GD76907@haasn.xyz>
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
In-Reply-To: <3d6a36d1-d9fb-4090-a286-382a6379fa42@gmail.com>
References: <20240315120442.73754-1-ffmpeg@haasn.xyz>
 <20240315120442.73754-3-ffmpeg@haasn.xyz>
 <3d6a36d1-d9fb-4090-a286-382a6379fa42@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
Subject: Re: [FFmpeg-devel] [PATCH v3 2/9] avcodec/av1dec: initialize AFGS1
 VSC metadata
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20240315132347.GD76907@haasn.xyz/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Fri, 15 Mar 2024 09:20:04 -0300 James Almer <jamrial@gmail.com> wrote:
> On 3/15/2024 8:58 AM, Niklas Haas wrote:
> > From: Niklas Haas <git@haasn.dev>
> > 
> > Unused by AV1, but should still be set properly.
> 
> The doxy for av_film_grain_params_alloc() says "Allocate an 
> AVFilmGrainParams structure and set its fields to default values", so 
> this should be done there.

This function doesn't know whether the film grain is of type AV1 or
H274, and so cannot set the correct codec-specific parameter defaults.

Unless, of course, we add these fields to the common struct, as
discussed above. (Or if we add the type to the function signature)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".