From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5864649F0D for ; Thu, 14 Mar 2024 22:57:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4A6E168CF9D; Fri, 15 Mar 2024 00:57:34 +0200 (EET) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3258368C9C7 for ; Fri, 15 Mar 2024 00:57:27 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 8783A1C0004 for ; Thu, 14 Mar 2024 22:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1710457046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eqXbUU1YTvfwqgWbd21jh/cUt9MVX8TjHrUt5ofpWlw=; b=m9X1ItFVIXxr2O6xm8uTKFxy2rWcTjzdXGNIa3I8wKRCmj6ox46Xy4eTewIIikXWf6x/gL IEnTBRwQgJqi3bUXr4wIs/yQ9W4uiaBWGQf2WiBPf3qANHJzXwOLlY8H5WDHGr6XGHEvr6 gKZ+aJHHOtXOhZ7G9I48B+sG8PnZhT08HaHHLEQoSbmJgaKjtg/B7klUjOTVuLSI0Vo/YM fVyATqTE3mslNUHRDS4rln6mIAnd/QN23MNbZenEv1X5pUgEFWfEOZ3yC2NaaP8KPuP14L OSFoBa9bov8NXr99+1gKsLVuD8Qs4nRvu6rzDW1hjpPY708pYLXwJhog2UDV2A== Date: Thu, 14 Mar 2024 23:57:25 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240314225725.GF6420@pb2> References: <20240314154300.3748-1-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20240314154300.3748-1-jamrial@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: force experimental flag for VVC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7517958376097117647==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7517958376097117647== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6tukXipI7WWNvWJd" Content-Disposition: inline --6tukXipI7WWNvWJd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 14, 2024 at 12:43:00PM -0300, James Almer wrote: > Otherwise the decoder will not even open. >=20 > Signed-off-by: James Almer > --- > tools/target_dec_fuzzer.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c > index 84b646b7f4..459b07070e 100644 > --- a/tools/target_dec_fuzzer.c > +++ b/tools/target_dec_fuzzer.c > @@ -176,6 +176,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_= t size) { > AVCodecParserContext *parser =3D NULL; > uint64_t keyframes =3D 0; > uint64_t flushpattern =3D -1; > + int strict_std_compliance =3D 0; > AVDictionary *opts =3D NULL; > =20 > if (!c) { > @@ -307,6 +308,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_= t size) { > case AV_CODEC_ID_VP6A: maxpixels /=3D 4096; break; > case AV_CODEC_ID_VP7: maxpixels /=3D 256; break; > case AV_CODEC_ID_VP9: maxpixels /=3D 4096; break; > + case AV_CODEC_ID_VVC: strict_std_compliance =3D FF_COMPLIANC= E_EXPERIMENTAL; break; > case AV_CODEC_ID_WAVPACK: maxsamples /=3D 1024; break; > case AV_CODEC_ID_WCMV: maxpixels /=3D 1024; break; > case AV_CODEC_ID_WMV3IMAGE: maxpixels /=3D 8192; break; > @@ -333,6 +335,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_= t size) { > =20 > ctx->max_samples =3D maxsamples_per_frame; > ctx->get_buffer2 =3D fuzz_get_buffer2; > + ctx->strict_std_compliance =3D strict_std_compliance; > =20 > if (size > 1024) { > GetByteContext gbc; I think this should look more like if( decoder is AV_CODEC_CAP_EXPERIMENTAL && strict_std_compliance too high) strict_std_compliance =3D FF_COMPLIANCE_EXPERIMENTAL i would not expect to see a check for AV_CODEC_ID_VVC in the patch thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that one is less smart than the original author, trying to rewrite it will not make it better. --6tukXipI7WWNvWJd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZfOA1QAKCRBhHseHBAsP q/AkAJ0dFrhwSdlKaw0AhN0heuPjVXrJoQCbB70Bdz0IPOfVUQxGsBCMV2wPaKc= =CIrQ -----END PGP SIGNATURE----- --6tukXipI7WWNvWJd-- --===============7517958376097117647== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7517958376097117647==--