From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 28F9C49F17 for ; Thu, 14 Mar 2024 22:41:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C304F68CBBC; Fri, 15 Mar 2024 00:41:24 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2835A68C558 for ; Fri, 15 Mar 2024 00:41:18 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5394360004 for ; Thu, 14 Mar 2024 22:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1710456077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TAZD5wVsKr0vrzqWHpgRZbfPT781m40JobhncIKm2PQ=; b=iy71xCRHlg2iqxk67vjzKXvc/j4RC5HqM9CQiJyTdOhb4K7oCRqTqCdDPSKNxsqaoTTxxS 5YDEtg1Kp/cmiQO/FREb1grA4UBUrTst5WI9bl21ipVzDfL6Ylm0eXbBt3tUH5DTVNNMiN 05+PSvR74GU4CtMZ2Hs9h0R3Xi6Qj+EdsH1Lns1H7qd1ja3VxZS4aJKvkm2wIzqoswuatV tqF/+QrqyH1FcmeWB9TGOtoAyVZLi+q79XHd2Gq8GpIk/cO05EAbd3oQ+7BnKkqyNKBIEd IE47BxP6wB47usF6TTW8d1xGy9MtTsL75UN2HNuBsLpHHVBpeU7PwcLHJVwlGw== Date: Thu, 14 Mar 2024 23:41:16 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240314224116.GD6420@pb2> References: <20240314175739.1499196-1-nicolas.gaullier@cji.paris> <20240314175739.1499196-2-nicolas.gaullier@cji.paris> MIME-Version: 1.0 In-Reply-To: <20240314175739.1499196-2-nicolas.gaullier@cji.paris> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/1] avformat/demux: Fix accurate probing of durations in mpegts/ps X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5418658296671940422==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5418658296671940422== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+Y4sjcOoAE5XvzaS" Content-Disposition: inline --+Y4sjcOoAE5XvzaS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 14, 2024 at 06:57:39PM +0100, Nicolas Gaullier wrote: > Two issues affect accuracy of duration in estimate_timings_from_pts(): > - pkt->duration typically reports the duration of a single audio frame, > whereas a pes often contain several audio frames > - for video, compute_frame_duration() use r_frame_rate which is not > reliable; typically, it is the duration of a single field for an > interlaced video using two field pictures. >=20 > Packet splitting/parsing is required to get accurate durations, so this > patch replaces ff_read_packet() calls by av_read_frame() calls. >=20 > Note that concatdec makes use of avformat_find_stream_info() to stitch > correctly the files, so it benefits from this patch (typically, overlap > is avoided). > e.g. in fate/concat-demuxer-simple2-lavf-ts: the input audio stream > duration is now longer than that of the video, which results in > concatdec joining on audio after the patch instead of joining on video > before that. >=20 > Signed-off-by: Nicolas Gaullier > --- > libavformat/demux.c | 30 +--- > tests/ref/fate/concat-demuxer-simple2-lavf-ts | 170 +++++++++--------- > tests/ref/fate/ts-opus-demux | 4 +- > 3 files changed, 93 insertions(+), 111 deletions(-) for some reason this seems to loose a resolution of some subtitle stream wh= en probing: make -j32 && ./ffprobe -v 99 -analyzeduration 2G -probesize 2G -i tickets/2= 471/part.ts 2>&1 | grep dvb_teletext Stream #0:2[0x240](eng), 1020, 1/90000: Subtitle: dvb_teletext (libzvbi_t= eletextdec) ([6][0][0][0] / 0x0006), 492x250 Stream #0:4[0x247](eng), 1902, 1/90000: Subtitle: dvb_teletext (libzvbi_t= eletextdec) ([6][0][0][0] / 0x0006), 492x250 vs. Stream #0:2[0x240](eng), 1020, 1/90000: Subtitle: dvb_teletext (libzvbi_t= eletextdec) ([6][0][0][0] / 0x0006), 492x250 Stream #0:4[0x247](eng), 1902, 1/90000: Subtitle: dvb_teletext (libzvbi_t= eletextdec) ([6][0][0][0] / 0x0006) ive not looked at this so i have no idea this is a bug, just wanted to repo= rt it thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented speaking, but never of holding my tongue. -- Xenocrates --+Y4sjcOoAE5XvzaS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZfN9BQAKCRBhHseHBAsP q/tCAJ4/s1Zg9PU1BgE0pbbE8TlPS9B/zgCeO/3mvNR1hgbT5E0UNGNk+I2gZXI= =JgHY -----END PGP SIGNATURE----- --+Y4sjcOoAE5XvzaS-- --===============5418658296671940422== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5418658296671940422==--