From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 33FA5495D0
	for <ffmpegdev@gitmailbox.com>; Thu, 14 Mar 2024 21:14:02 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1EE3A68D18A;
	Thu, 14 Mar 2024 23:14:00 +0200 (EET)
Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net
 [217.70.183.197])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C7E4368C8EA
 for <ffmpeg-devel@ffmpeg.org>; Thu, 14 Mar 2024 23:13:53 +0200 (EET)
Received: by mail.gandi.net (Postfix) with ESMTPSA id 013201C0003
 for <ffmpeg-devel@ffmpeg.org>; Thu, 14 Mar 2024 21:13:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
 s=gm1; t=1710450833;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=+cd7LQr9WiEbFgNoPo0rk5aeN1iYG3mHebcEELZL1aU=;
 b=kjTVAz5GxWtyLF1JMR7MvA2V/ZNEL1W80regO1b6HoxcJqJtHdNKAlPvBUJ/cGMCNkXdyF
 CHl405k5R5EZYYto834g8Xw8nquV/9stmkYN/WgVjqN+5gQRnm6qUgEBuALuzMMiy8mAIQ
 afM5oVgaHRk1krFfhttlIP4/ZP880NiCr4uz6DKBDbfgAnkOrjsw2v0DPT2GoPferQGbzm
 hEtGNDIY/LsQLeQMGSRwrJCBL4xvUhrMaC0gwWa0bx9TVZI2omwZBsc+kr9JVPUv7+G50M
 uZFkwDbu6azLVpOwvFLcfm6ryNJ/Q9bCjijNfCocRHZXgCqPLbjrEdTdveJ3Ng==
Date: Thu, 14 Mar 2024 22:13:52 +0100
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20240314211352.GB6420@pb2>
References: <AS8P193MB199731D2B920E976CEF231CE8D292@AS8P193MB1997.EURP193.PROD.OUTLOOK.COM>
MIME-Version: 1.0
In-Reply-To: <AS8P193MB199731D2B920E976CEF231CE8D292@AS8P193MB1997.EURP193.PROD.OUTLOOK.COM>
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH] avformat: enable UDP IPv6 multicast
 interface selection
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============5443799393616027614=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20240314211352.GB6420@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============5443799393616027614==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="/8nRXpHy+lHfjtUh"
Content-Disposition: inline


--/8nRXpHy+lHfjtUh
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 14, 2024 at 12:04:47PM +0000, Ignjatovi=C4=87, Lazar (RS) wrote:
> localaddr option now properly works with IPv6 addresses. Properly
> resolved interface index in places where default 0 interface index is
> used (marked with TODO: within udp.c). Added SO_BINDTODEVICE for mcast
> sockets that are used for reading from the network. Need for this
> arises from the fact that [ffx1::*] and [ffx2::*] mcast addresses need
> to have a defined interface for binding to avoid ambiguity between
> multiple link-local networks on the same host. Failing to set this
> option causes errors on Linux systems for interface and link-local
> scopes.
>=20
> For mcast addresses, bind to mcast address is attempted as before.
> In case that this fails, which will happen on Windows, socket is bound
> to INADDR_ANY/IN6ADDR_ANY_INIT depending on address family. Actual
> interface selection is performed using udp_set_multicast_interface to
> point to the desired interface for sending/listening.
>=20
> Utilization of sin6_scope_id field enables usage and adequate resolving
> of IPv6 addresses that utilize zone index
> (e.g. fe80::1ff:fe23:4567:890a%eth2)
> This is not fully supported on Windows, thus relying on this field
> is not done on Windows systems.
>=20
> Closes: #368
>=20
> Signed-off-by: Lazar Ignjatovic <Lazar.Ignjatovic@cubic.com>
> ---
>  configure             |  3 ++
>  libavformat/ip.c      | 45 ++++++++++++++++++++++++
>  libavformat/ip.h      |  6 ++++
>  libavformat/network.h |  6 ++++
>  libavformat/udp.c     | 80 ++++++++++++++++++++++++++++++++++++++-----
>  5 files changed, 132 insertions(+), 8 deletions(-)

breaks mingw64 build

CC	libavformat/ip.o
src/libavformat/ip.c: In function =E2=80=98ff_ip_resolve_interface_index=E2=
=80=99:
src/libavformat/ip.c:206:1: error: control reaches end of non-void function=
 [-Werror=3Dreturn-type]
 }
 ^
cc1: some warnings being treated as errors
src/ffbuild/common.mak:81: recipe for target 'libavformat/ip.o' failed
make: *** [libavformat/ip.o] Error 1

also configure produces
=2E./configure: 6415: ../configure: network_extralibs+=3D -liphlpapi: not f=
ound


[...]
--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus

--/8nRXpHy+lHfjtUh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZfNoiQAKCRBhHseHBAsP
qygJAJwJY6ZT2E7cdDXosn+ha3ixhrMczwCglrgDw1GCje8KYSxQNZMXtPcHbi4=
=6bXh
-----END PGP SIGNATURE-----

--/8nRXpHy+lHfjtUh--

--===============5443799393616027614==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============5443799393616027614==--