[FFmpeg-devel] [PATCH] doc/fate: advise on --assert-level=2

[FFmpeg-devel] [PATCH] doc/fate: advise on --assert-level=2

[Nicolas Gaullier]

Signed-off-by: Nicolas Gaullier <nicolas.gaullier@cji.paris>
---
 doc/fate.texi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/doc/fate.texi b/doc/fate.texi
index 2fa8c34c2d..17644ce65a 100644
--- a/doc/fate.texi
+++ b/doc/fate.texi
@@ -79,6 +79,14 @@ Do not put a '~' character in the samples path to indicate a home
 directory. Because of shell nuances, this will cause FATE to fail.
 @end float
 
+Beware that some assertions are disabled by default, so mind setting
+@option{--assert-level=<level>} at configuration time, e.g. when seeking
+the highest possible test coverage:
+@example
+./configure --assert-level=2
+@end example
+Note that raising the assert level could have a performance impact.
+
 To get the complete list of tests, run the command:
 @example
 make fate-list
-- 
2.30.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/fate: advise on --assert-level=2

[Nicolas Gaullier]

>De : Nicolas Gaullier <nicolas.gaullier@cji.paris> 
>Envoyé : mardi 12 mars 2024 13:09
>Objet : [PATCH] doc/fate: advise on --assert-level=2
>
>diff --git a/doc/fate.texi b/doc/fate.texi index 2fa8c34c2d..17644ce65a 100644
>--- a/doc/fate.texi
>+++ b/doc/fate.texi
>@@ -79,6 +79,14 @@ Do not put a '~' character in the samples path to indicate a home  directory. Because of shell nuances, this will cause FATE to fail.
> @end float
> 
>+Beware that some assertions are disabled by default, so mind setting 
>+@option{--assert-level=<level>} at configuration time, e.g. when 
>+seeking the highest possible test coverage:
>+@example
>+./configure --assert-level=2
>+@end example
>+Note that raising the assert level could have a performance impact.

Ping ? (I forgot to raise the version to v2, but it actually includes a notice on performance impact following Michael's comment)
Feel free to amend/reauthor if my english is not good enough.

Nicolas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/fate: advise on --assert-level=2

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 502 bytes --]

On Tue, Mar 12, 2024 at 01:09:20PM +0100, Nicolas Gaullier wrote:
> Signed-off-by: Nicolas Gaullier <nicolas.gaullier@cji.paris>
> ---
>  doc/fate.texi | 8 ++++++++
>  1 file changed, 8 insertions(+)

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 0/1] doc/fate: advise on --assert-level=2

[Nicolas Gaullier]

In my personnal experience, when running fate, --assert-level=2 has a very limited performance impact,
so I think it can be recommended without further attention.

Nicolas Gaullier (1):
  doc/fate: advise on --assert-level=2

 doc/fate.texi | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.30.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] doc/fate: advise on --assert-level=2

[Nicolas Gaullier]

Signed-off-by: Nicolas Gaullier <nicolas.gaullier@cji.paris>
---
 doc/fate.texi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/fate.texi b/doc/fate.texi
index 2fa8c34c2d..2fa7c70251 100644
--- a/doc/fate.texi
+++ b/doc/fate.texi
@@ -79,6 +79,13 @@ Do not put a '~' character in the samples path to indicate a home
 directory. Because of shell nuances, this will cause FATE to fail.
 @end float
 
+Beware that some assertions are disabled by default, so mind setting
+@option{--assert-level=<level>} at configuration time, e.g. when seeking
+the highest possible test coverage:
+@example
+./configure --assert-level=2
+@end example
+
 To get the complete list of tests, run the command:
 @example
 make fate-list
-- 
2.30.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/fate: advise on --assert-level=2

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1131 bytes --]

On Mon, Mar 11, 2024 at 11:16:06AM +0100, Nicolas Gaullier wrote:
> Signed-off-by: Nicolas Gaullier <nicolas.gaullier@cji.paris>
> ---
>  doc/fate.texi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/doc/fate.texi b/doc/fate.texi
> index 2fa8c34c2d..2fa7c70251 100644
> --- a/doc/fate.texi
> +++ b/doc/fate.texi
> @@ -79,6 +79,13 @@ Do not put a '~' character in the samples path to indicate a home
>  directory. Because of shell nuances, this will cause FATE to fail.
>  @end float
>  
> +Beware that some assertions are disabled by default, so mind setting
> +@option{--assert-level=<level>} at configuration time, e.g. when seeking
> +the highest possible test coverage:
> +@example
> +./configure --assert-level=2
> +@end example

This (or some other appropriate place in the docs)
should mention that doing so could have a performance impact

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".