From: Stefano Sabatini <stefasab@gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: Stefano Sabatini <stefasab@gmail.com> Subject: [FFmpeg-devel] [PATCH 2/3] lavf/fifo_test: use FifoTest in place of Failing Date: Tue, 12 Mar 2024 11:56:53 +0100 Message-ID: <20240312105654.342835-2-stefasab@gmail.com> (raw) In-Reply-To: <20240312105654.342835-1-stefasab@gmail.com> Use a more consistent and sensible prefix for the muxer structs and functions. --- libavformat/fifo_test.c | 45 ++++++++++++++++++++--------------------- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/libavformat/fifo_test.c b/libavformat/fifo_test.c index 84b762db5f..903f4bc34b 100644 --- a/libavformat/fifo_test.c +++ b/libavformat/fifo_test.c @@ -1,5 +1,5 @@ /* - * FIFO test pseudo-muxer + * FIFO pseudo-muxer test * Copyright (c) 2016 Jan Sebechlebsky * * This file is part of FFmpeg. @@ -38,14 +38,13 @@ /* This is structure of data sent in packets to * failing muxer */ -typedef struct FailingMuxerPacketData { +typedef struct FifoTestMuxerPacketData { int ret; /* return value of write_packet call*/ int recover_after; /* set ret to zero after this number of recovery attempts */ unsigned sleep_time; /* sleep for this long in write_packet to simulate long I/O operation */ -} FailingMuxerPacketData; +} FifoTestMuxerPacketData; - -typedef struct FailingMuxerContext { +typedef struct FifoTestMuxerContext { AVClass *class; int write_header_ret; int write_trailer_ret; @@ -55,22 +54,22 @@ typedef struct FailingMuxerContext { int flush_count; int pts_written[MAX_TST_PACKETS]; int pts_written_nr; -} FailingMuxerContext; +} FifoTestMuxerContext; -static int failing_write_header(AVFormatContext *avf) +static int fifo_test_write_header(AVFormatContext *avf) { - FailingMuxerContext *ctx = avf->priv_data; + FifoTestMuxerContext *ctx = avf->priv_data; return ctx->write_header_ret; } -static int failing_write_packet(AVFormatContext *avf, AVPacket *pkt) +static int fifo_test_write_packet(AVFormatContext *avf, AVPacket *pkt) { - FailingMuxerContext *ctx = avf->priv_data; + FifoTestMuxerContext *ctx = avf->priv_data; int ret = 0; if (!pkt) { ctx->flush_count++; } else { - FailingMuxerPacketData *data = (FailingMuxerPacketData*) pkt->data; + FifoTestMuxerPacketData *data = (FifoTestMuxerPacketData*) pkt->data; if (!data->recover_after) { data->ret = 0; @@ -98,16 +97,16 @@ static int failing_write_packet(AVFormatContext *avf, AVPacket *pkt) return ret; } -static int failing_write_trailer(AVFormatContext *avf) +static int fifo_test_write_trailer(AVFormatContext *avf) { - FailingMuxerContext *ctx = avf->priv_data; + FifoTestMuxerContext *ctx = avf->priv_data; return ctx->write_trailer_ret; } -static void failing_deinit(AVFormatContext *avf) +static void fifo_test_deinit(AVFormatContext *avf) { int i; - FailingMuxerContext *ctx = avf->priv_data; + FifoTestMuxerContext *ctx = avf->priv_data; if (!ctx->print_deinit_summary) return; @@ -120,7 +119,7 @@ static void failing_deinit(AVFormatContext *avf) } printf("\n"); } -#define OFFSET(x) offsetof(FailingMuxerContext, x) +#define OFFSET(x) offsetof(FifoTestMuxerContext, x) static const AVOption options[] = { {"print_deinit_summary", "print summary when deinitializing muxer", OFFSET(print_deinit_summary), AV_OPT_TYPE_BOOL, {.i64 = 1}, 0, 1, AV_OPT_FLAG_ENCODING_PARAM}, @@ -131,7 +130,7 @@ static const AVOption options[] = { {NULL} }; -static const AVClass failing_muxer_class = { +static const AVClass fifo_test_muxer_class = { .class_name = "Fifo test muxer", .item_name = av_default_item_name, .option = options, @@ -141,12 +140,12 @@ static const AVClass failing_muxer_class = { const FFOutputFormat ff_fifo_test_muxer = { .p.name = "fifo_test", .p.long_name = NULL_IF_CONFIG_SMALL("Fifo test muxer"), - .priv_data_size = sizeof(FailingMuxerContext), - .write_header = failing_write_header, - .write_packet = failing_write_packet, - .write_trailer = failing_write_trailer, - .deinit = failing_deinit, - .p.priv_class = &failing_muxer_class, + .priv_data_size = sizeof(FifoTestMuxerContext), + .write_header = fifo_test_write_header, + .write_packet = fifo_test_write_packet, + .write_trailer = fifo_test_write_trailer, + .deinit = fifo_test_deinit, + .p.priv_class = &fifo_test_muxer_class, #if FF_API_ALLOW_FLUSH .p.flags = AVFMT_NOFILE | AVFMT_ALLOW_FLUSH, #else -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-12 10:57 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-12 10:56 [FFmpeg-devel] [PATCH 1/3] lavf/fifo_test: sort options by name Stefano Sabatini 2024-03-12 10:56 ` Stefano Sabatini [this message] 2024-03-12 10:56 ` [FFmpeg-devel] [PATCH 3/3] doc/muxers: add fifo_test Stefano Sabatini 2024-03-12 12:25 ` Andreas Rheinhardt 2024-03-12 16:57 ` Stefano Sabatini 2024-03-12 18:55 ` Andreas Rheinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240312105654.342835-2-stefasab@gmail.com \ --to=stefasab@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git