From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id C9E5F4863F
	for <ffmpegdev@gitmailbox.com>; Tue, 12 Mar 2024 00:49:29 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E3B4668D0B4;
	Tue, 12 Mar 2024 02:49:26 +0200 (EET)
Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net
 [217.70.183.194])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0553368C719
 for <ffmpeg-devel@ffmpeg.org>; Tue, 12 Mar 2024 02:49:20 +0200 (EET)
Received: by mail.gandi.net (Postfix) with ESMTPSA id 1BCB240004
 for <ffmpeg-devel@ffmpeg.org>; Tue, 12 Mar 2024 00:49:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
 s=gm1; t=1710204560;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=Ulr6fy1BMmI3HSdbQkg5DYT+2wEhS5rMqbvt9dE2BJY=;
 b=HvOj9Lw/tq6aS4pMK/vZltr0BBoqI0+sonzkP5eq8PgLY2Vq+Kbdn0M80tRsXtXCLE/mLk
 hafCKn4OXxLNZi9Nyy9Bic49kNbzbU62VYWljcnP4uC7+2r7oAMioSdZeMEsq+yyB9sQ4P
 jMdKj71FItp+F06X3G5U757kM2SUyNai3liv76Id5eVYqrZjmNJyS2NldVS8lnzIkLgvjq
 SamkhaI5MLlmNqSoNqNn/9fkELDl/VPJ7pAB0PfRli8Xe3AYJG576vy3JR58WRhOKxRj+/
 ApOAgPfxtMZFDsiQija2hY69nyrzOZg2G8+wq5GU8bRXNa56Q760DDx5ZDO/EA==
Date: Tue, 12 Mar 2024 01:49:19 +0100
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20240312004919.GV6420@pb2>
References: <20240311185331.84556-1-post@frankplowman.com>
MIME-Version: 1.0
In-Reply-To: <20240311185331.84556-1-post@frankplowman.com>
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH] lavc/vvc: AVERROR_PATCHWELCOME for
 subpictures
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============0279363523082138498=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20240312004919.GV6420@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============0279363523082138498==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="oePIYWiiPUoG1XvJ"
Content-Disposition: inline


--oePIYWiiPUoG1XvJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 11, 2024 at 06:53:31PM +0000, Frank Plowman wrote:
> VVC's subpictures feature is not yet implemented in the native decoder.
> Throw an AVERROR_PATCHWELCOME when trying to decode a bitstream using
> the feature.  Fixes crashes when trying to decode bitstreams which
> use the feature.
>=20
> Signed-off-by: Frank Plowman <post@frankplowman.com>
> ---
>  libavcodec/vvc/vvc_ps.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)

This breaks fate-vvc-conformance-SUBPIC_A_3

make fate-vvc-conformance-SUBPIC_A_3
TEST    vvc-conformance-SUBPIC_A_3
--- ./tests/ref/fate/vvc-conformance-SUBPIC_A_3	2024-03-05 02:37:36.2353001=
41 +0100
+++ tests/data/fate/vvc-conformance-SUBPIC_A_3	2024-03-12 01:47:27.30159356=
7 +0100
@@ -1,9 +0,0 @@
-#tb 0: 1/25
-#media_type 0: video
-#codec_id 0: rawvideo
-#dimensions 0: 1920x1080
-#sar 0: 0/1
-0,          0,          0,        1,  6220800, 0xa419cfb6
-0,          1,          1,        1,  6220800, 0xa419cfb6
-0,          2,          2,        1,  6220800, 0xa419cfb6
-0,          3,          3,        1,  6220800, 0xa419cfb6
Test vvc-conformance-SUBPIC_A_3 failed. Look at tests/data/fate/vvc-conform=
ance-SUBPIC_A_3.err for details.
tests/Makefile:318: recipe for target 'fate-vvc-conformance-SUBPIC_A_3' fai=
led
make: *** [fate-vvc-conformance-SUBPIC_A_3] Error 69

thx

[...]
--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew .=
=2E."

--oePIYWiiPUoG1XvJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZe+miAAKCRBhHseHBAsP
q2hvAJ9/lpqdoCv8+ckRj0M6TSezqXQoAgCfbXCnAivk6WzyN5ii/4zEo42/B08=
=Pjdl
-----END PGP SIGNATURE-----

--oePIYWiiPUoG1XvJ--

--===============0279363523082138498==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============0279363523082138498==--