From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/vvc: AVERROR_PATCHWELCOME for subpictures
Date: Tue, 12 Mar 2024 01:49:19 +0100
Message-ID: <20240312004919.GV6420@pb2> (raw)
In-Reply-To: <20240311185331.84556-1-post@frankplowman.com>
[-- Attachment #1.1: Type: text/plain, Size: 1693 bytes --]
On Mon, Mar 11, 2024 at 06:53:31PM +0000, Frank Plowman wrote:
> VVC's subpictures feature is not yet implemented in the native decoder.
> Throw an AVERROR_PATCHWELCOME when trying to decode a bitstream using
> the feature. Fixes crashes when trying to decode bitstreams which
> use the feature.
>
> Signed-off-by: Frank Plowman <post@frankplowman.com>
> ---
> libavcodec/vvc/vvc_ps.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
This breaks fate-vvc-conformance-SUBPIC_A_3
make fate-vvc-conformance-SUBPIC_A_3
TEST vvc-conformance-SUBPIC_A_3
--- ./tests/ref/fate/vvc-conformance-SUBPIC_A_3 2024-03-05 02:37:36.235300141 +0100
+++ tests/data/fate/vvc-conformance-SUBPIC_A_3 2024-03-12 01:47:27.301593567 +0100
@@ -1,9 +0,0 @@
-#tb 0: 1/25
-#media_type 0: video
-#codec_id 0: rawvideo
-#dimensions 0: 1920x1080
-#sar 0: 0/1
-0, 0, 0, 1, 6220800, 0xa419cfb6
-0, 1, 1, 1, 6220800, 0xa419cfb6
-0, 2, 2, 1, 6220800, 0xa419cfb6
-0, 3, 3, 1, 6220800, 0xa419cfb6
Test vvc-conformance-SUBPIC_A_3 failed. Look at tests/data/fate/vvc-conformance-SUBPIC_A_3.err for details.
tests/Makefile:318: recipe for target 'fate-vvc-conformance-SUBPIC_A_3' failed
make: *** [fate-vvc-conformance-SUBPIC_A_3] Error 69
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The real ebay dictionary, page 1
"Used only once" - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-12 0:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 18:53 Frank Plowman
2024-03-12 0:49 ` Michael Niedermayer [this message]
2024-03-12 0:57 ` James Almer
2024-03-12 3:33 ` Wang, Fei W
2024-03-12 9:09 ` Frank Plowman
2024-03-12 12:48 ` Nuo Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312004919.GV6420@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git