From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9A97749DF5 for ; Mon, 11 Mar 2024 21:44:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8445968D0CF; Mon, 11 Mar 2024 23:43:58 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34B8B68C1D5 for ; Mon, 11 Mar 2024 23:43:52 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 68F6720003 for ; Mon, 11 Mar 2024 21:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1710193431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ufe9bkBZ7nthLRXAIkYPwmqJYFKVuvYZBePQLtwAoLw=; b=Fui7jyK2ZYy1iBsuPIzJUU9PZ0Q6fK5mt7wADWRYEEGAY6XCq+Ma9Su/R6om/qPomsJyD6 MAypgygDUexD9ZEe2mnrHWQgIaPgmnJrIbkN4OUZQyV3hkO4O1QStzc8MkjEWkmvNlPcgL 4HBQFeDD6nNoUY+46poRqw5S0kQS+OC9NZAHOJtw3MyHzqI4niOrYJPa4pQL10pbrCZZuq dMGTvmephid4qpbqbgkP+SZhpgNgyHE6z0cVlE9Z49eEqhizdKorRef9MmwVH6fPZ52ALN d1fz/AkflgyADW6cVUPEtT+tiB7JlR84jZVTxAA166eA22xpPs9BQHlbADxJAA== Date: Mon, 11 Mar 2024 22:43:50 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240311214350.GU6420@pb2> References: <20240311004047.140612-1-marth64@proxyid.net> MIME-Version: 1.0 In-Reply-To: <20240311004047.140612-1-marth64@proxyid.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: don't print multiple \pos tags per cue X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7600142714348126155==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7600142714348126155== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BBkQ9QvnYIW9THct" Content-Disposition: inline --BBkQ9QvnYIW9THct Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 10, 2024 at 07:40:47PM -0500, Marth64 wrote: > Currently, Closed Captions decoder prints multiple \pos ASS tags per line, > per cue. This is invalid behavior, because only the first \pos tag in a c= ue > is honored by ASS anyway. Don't write multiple \pos tags. >=20 > Signed-off-by: Marth64 > --- > libavcodec/ccaption_dec.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) This breaks fate --- ./tests/ref/fate/sub-cc-scte20 2024-03-05 02:37:36.223299993 +0100 +++ tests/data/fate/sub-cc-scte20 2024-03-11 22:13:08.091910294 +0100 @@ -13,5 +13,5 @@ [Events] Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect,= Text Dialogue: 0,0:00:00.00,0:00:01.44,Default,,0,0,0,,{\an7}{\pos(48,182)}BESI= DES THE -Dialogue: 0,0:00:01.43,0:00:03.93,Default,,0,0,0,,{\an7}{\pos(38,166)}\hBE= SIDES THE \N{\an7}{\pos(38,197)}SPENDING AND THIS, IS THAT CAR -Dialogue: 0,0:00:03.94,0:00:06.31,Default,,0,0,0,,{\an7}{\pos(38,182)}SPEN= DING AND THIS, IS THAT CAR \N{\an7}{\pos(38,197)}MANUFACTURERS ARE ABOUT AS +Dialogue: 0,0:00:01.43,0:00:03.93,Default,,0,0,0,,{\an7}{\pos(38,166)}\hBE= SIDES THE \NSPENDING AND THIS, IS THAT CAR +Dialogue: 0,0:00:03.94,0:00:06.31,Default,,0,0,0,,{\an7}{\pos(38,182)}SPEN= DING AND THIS, IS THAT CAR \NMANUFACTURERS ARE ABOUT AS Test sub-cc-scte20 failed. Look at tests/data/fate/sub-cc-scte20.err for de= tails. [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Nations do behave wisely once they have exhausted all other alternatives.= =20 -- Abba Eban --BBkQ9QvnYIW9THct Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZe97EAAKCRBhHseHBAsP q77rAJ4zQYbk1GWr+lto3BtQhxJiEx8nngCdEYJJ5qaYx2/h4msfpHPZ0aCcNX4= =p6kT -----END PGP SIGNATURE----- --BBkQ9QvnYIW9THct-- --===============7600142714348126155== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7600142714348126155==--