From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 15D7B48146 for ; Sun, 10 Mar 2024 19:21:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 61B9368CE4C; Sun, 10 Mar 2024 21:21:56 +0200 (EET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 88E1D68C8EA for ; Sun, 10 Mar 2024 21:21:49 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 872F3240002 for ; Sun, 10 Mar 2024 19:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1710098508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hFY6CBj602J6j+mbgC+6Ir/GbAjH5TyjoGYaLMhTSN4=; b=ftvDICJt1KTZ3vZ1TdAPwbXc0UmKekqgj9FYGVoyHF7LShV2ncUJymoqQYYotwwq19tOvY WMzn0KYxMYODUGmXfBu/QJtXr3WoxfUY0JCjNgbAPerydlmR6L93ZEyjSGX562KuzR0i5l EcofMdY4tPAKRXHVwQhW2sEn+TaLPmteaI0xOk09qVmEM24lLZ3/f3HD5hbuc/YUc4Iew4 Ysl+N73RYgzzTQY8K2ubNl6RlFpS53GIRG3U9Frch8iFxjw8bWG0aC/ibw/2LWABygn7er 2OXu2gjyyCGHuFnIzACfBEgBTjA8tUFxw/IW34tQuuRjDjY40EV8FpBTFl9R7g== Date: Sun, 10 Mar 2024 20:21:47 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240310192147.GQ6420@pb2> References: <20240306110319.17339-1-anton@khirnov.net> <20240306110319.17339-2-anton@khirnov.net> <20240307203739.GI6420@pb2> <170987607651.7287.4766174024309496140@lain.khirnov.net> <20240310033629.GM6420@pb2> <171005119864.662.10837664362214202636@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <171005119864.662.10837664362214202636@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 02/18] fftools/ffmpeg_filter: refactor setting input timebase X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5721310200158867101==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5721310200158867101== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hus2cxLD2ItTW9sf" Content-Disposition: inline --hus2cxLD2ItTW9sf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 10, 2024 at 07:13:18AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-03-10 04:36:29) > > On Fri, Mar 08, 2024 at 06:34:36AM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-03-07 21:37:39) > > > > On Wed, Mar 06, 2024 at 12:03:03PM +0100, Anton Khirnov wrote: > > > > > Treat it analogously to stream parameters like format/dimensions/= etc. > > > > > This is functionally different from previous code in 2 ways: > > > > > * for non-CFR video, the frame timebase (set by the decoder) is u= sed > > > > > rather than the demuxer timebase > > > > > * for sub2video, AV_TIME_BASE_Q is used, which is hardcoded by the > > > > > subtitle decoding API > > > > >=20 > > > > > These changes should avoid unnecessary and potentially lossy time= stamp > > > > > conversions from decoder timebase into the demuxer one. > > > > >=20 > > > > > Changes the timebases used in sub2video tests. > > > > > --- > > > > > fftools/ffmpeg_filter.c | 17 ++- > > > > > tests/ref/fate/sub2video_basic | 182 +++++++++++++-------= ------ > > > > > tests/ref/fate/sub2video_time_limited | 8 +- > > > > > 3 files changed, 106 insertions(+), 101 deletions(-) > > > >=20 > > > > breaks: > > > >=20 > > > > ./ffmpeg -i \[a-s\]_full_metal_panic_fumoffu_-_01_-_the_man_from_th= e_south_-_a_hostage_with_no_compromises__rs2_\[1080p_bd-rip\]\[BBB48A25\].m= kv -filter_complex '[0:s:1]scale=3D800:600' -t 15 -qscale 2 -y a.avi > > > >=20 > > >=20 > > > Use a constant framerate. > >=20 > > why not automatically choose a supported timebase ? > >=20 > > "[mpeg4 @ 0x55973c869f00] timebase 1/1000000 not supported by MPEG 4 st= andard, the maximum admitted value for the timebase denominator is 65535" >=20 > Because I don't want ffmpeg CLI to have codec-specific code for a codec > that's been obsolete for 15+ years. One could also potentially do it > inside the encoder itself, but it is nontrivial since the computations > are spread across a number of places in mpeg4videoenc.c and > mpegvideo_enc.c. And again, it seems like a waste of time - there is no > reason to encode mpeg4 today. This is not mpeg4 specific, its just a new additional case that fails =2E/ffmpeg -i mm-small.mpg test.dv [dvvideo @ 0x7f868800f100] Found no DV profile for 80x60 yuv420p video. Val= id DV profiles are: IMHO ffmpeg should be able to select supported parameters if the user indicated thats what he wants We also do this with pixel formats and not fail and require the user to man= ually specify it thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When the tyrant has disposed of foreign enemies by conquest or treaty, and there is nothing more to fear from them, then he is always stirring up some war or other, in order that the people may require a leader. -- Plato --hus2cxLD2ItTW9sf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZe4IQAAKCRBhHseHBAsP q31+AJ9l1BKlCDSJN9zLb6MrqCbmJOXZWQCbBof/rD9bWpfvDz1myYPtND/DExw= =TWot -----END PGP SIGNATURE----- --hus2cxLD2ItTW9sf-- --===============5721310200158867101== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5721310200158867101==--