From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2BB4B49D56 for ; Sun, 10 Mar 2024 03:36:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3F18C68CCAA; Sun, 10 Mar 2024 05:36:37 +0200 (EET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ACD7368BBB0 for ; Sun, 10 Mar 2024 05:36:30 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id BEDF31BF204 for ; Sun, 10 Mar 2024 03:36:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1710041789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RM2D67+exEUwXo15B0bSvmJZOxvGuJrb0tp1NxPgaO8=; b=VSo2uHf/4pwEOeVNt0+asw9rOZH1Q/mrRFVCQzcifgugl0QIUok4vVwZoWmlEQEGRHrlgK vdsefVotPTCG+sUIEWu0phVfdgHOhN4wgQbR1rTgYv8i+X2KDixnXz4mFG+w8j89+DC6vv 4EYZM5Er6etP8GnhKokUzGUfn5I4AAWivbN5SCiT+NG3NMak2YAy6AFQJYEkcuuW17QvVb HiNiD8OHdTuKlhMIqhnOoxPQjCb1h15SvCUgqH/CSP9fes+3Sy+EwQr/rIqi1L7k6oshcH RVmfEmhMecZsK71BRwMcRHTvzS3kPv25r2b97OP2EAlQbZ8zP3zY24dIrfYJAw== Date: Sun, 10 Mar 2024 04:36:29 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240310033629.GM6420@pb2> References: <20240306110319.17339-1-anton@khirnov.net> <20240306110319.17339-2-anton@khirnov.net> <20240307203739.GI6420@pb2> <170987607651.7287.4766174024309496140@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <170987607651.7287.4766174024309496140@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 02/18] fftools/ffmpeg_filter: refactor setting input timebase X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2493104352799392280==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2493104352799392280== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uaCpR1uf0tm6j4XV" Content-Disposition: inline --uaCpR1uf0tm6j4XV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 08, 2024 at 06:34:36AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-03-07 21:37:39) > > On Wed, Mar 06, 2024 at 12:03:03PM +0100, Anton Khirnov wrote: > > > Treat it analogously to stream parameters like format/dimensions/etc. > > > This is functionally different from previous code in 2 ways: > > > * for non-CFR video, the frame timebase (set by the decoder) is used > > > rather than the demuxer timebase > > > * for sub2video, AV_TIME_BASE_Q is used, which is hardcoded by the > > > subtitle decoding API > > >=20 > > > These changes should avoid unnecessary and potentially lossy timestamp > > > conversions from decoder timebase into the demuxer one. > > >=20 > > > Changes the timebases used in sub2video tests. > > > --- > > > fftools/ffmpeg_filter.c | 17 ++- > > > tests/ref/fate/sub2video_basic | 182 +++++++++++++-----------= -- > > > tests/ref/fate/sub2video_time_limited | 8 +- > > > 3 files changed, 106 insertions(+), 101 deletions(-) > >=20 > > breaks: > >=20 > > ./ffmpeg -i \[a-s\]_full_metal_panic_fumoffu_-_01_-_the_man_from_the_so= uth_-_a_hostage_with_no_compromises__rs2_\[1080p_bd-rip\]\[BBB48A25\].mkv = -filter_complex '[0:s:1]scale=3D800:600' -t 15 -qscale 2 -y a.avi > >=20 >=20 > Use a constant framerate. why not automatically choose a supported timebase ? "[mpeg4 @ 0x55973c869f00] timebase 1/1000000 not supported by MPEG 4 standa= rd, the maximum admitted value for the timebase denominator is 65535" ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way around the laws. -- Plato --uaCpR1uf0tm6j4XV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZe0quQAKCRBhHseHBAsP qyBJAJwIm1FCL215g4OgLg3kN8jWKb7aIACfTwDZLxTNINpcBoacV+RuUawBrcg= =8+cu -----END PGP SIGNATURE----- --uaCpR1uf0tm6j4XV-- --===============2493104352799392280== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2493104352799392280==--