* [FFmpeg-devel] [PATCH 1/2] avcodec/ccaption_dec: clarify log message when out-of-display columns are ignored
@ 2024-03-09 18:39 Marth64
2024-03-09 18:39 ` [FFmpeg-devel] [PATCH 2/2] avcodec/ccaption_dec: use consistent naming convention of Closed Captions Marth64
2024-03-10 14:11 ` [FFmpeg-devel] [PATCH 1/2] avcodec/ccaption_dec: clarify log message when out-of-display columns are ignored Stefano Sabatini
0 siblings, 2 replies; 4+ messages in thread
From: Marth64 @ 2024-03-09 18:39 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Marth64
Signed-off-by: Marth64 <marth64@proxyid.net>
---
libavcodec/ccaption_dec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c
index 1550e4b253..d03413265a 100644
--- a/libavcodec/ccaption_dec.c
+++ b/libavcodec/ccaption_dec.c
@@ -358,7 +358,7 @@ static void write_char(CCaptionSubContext *ctx, struct Screen *screen, char ch)
return;
}
else {
- av_log(ctx, AV_LOG_WARNING, "Data Ignored since exceeding screen width\n");
+ av_log(ctx, AV_LOG_WARNING, "Data ignored due to columns exceeding screen width\n");
return;
}
}
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* [FFmpeg-devel] [PATCH 2/2] avcodec/ccaption_dec: use consistent naming convention of Closed Captions
2024-03-09 18:39 [FFmpeg-devel] [PATCH 1/2] avcodec/ccaption_dec: clarify log message when out-of-display columns are ignored Marth64
@ 2024-03-09 18:39 ` Marth64
2024-03-10 14:12 ` Stefano Sabatini
2024-03-10 14:11 ` [FFmpeg-devel] [PATCH 1/2] avcodec/ccaption_dec: clarify log message when out-of-display columns are ignored Stefano Sabatini
1 sibling, 1 reply; 4+ messages in thread
From: Marth64 @ 2024-03-09 18:39 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Marth64
Signed-off-by: Marth64 <marth64@proxyid.net>
---
libavcodec/ccaption_dec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c
index d03413265a..faf058ce97 100644
--- a/libavcodec/ccaption_dec.c
+++ b/libavcodec/ccaption_dec.c
@@ -948,7 +948,7 @@ static const AVOption options[] = {
};
static const AVClass ccaption_dec_class = {
- .class_name = "Closed caption Decoder",
+ .class_name = "Closed Captions Decoder",
.item_name = av_default_item_name,
.option = options,
.version = LIBAVUTIL_VERSION_INT,
@@ -956,7 +956,7 @@ static const AVClass ccaption_dec_class = {
const FFCodec ff_ccaption_decoder = {
.p.name = "cc_dec",
- CODEC_LONG_NAME("Closed Caption (EIA-608 / CEA-708)"),
+ CODEC_LONG_NAME("Closed Captions (EIA-608 / CEA-708)"),
.p.type = AVMEDIA_TYPE_SUBTITLE,
.p.id = AV_CODEC_ID_EIA_608,
.p.priv_class = &ccaption_dec_class,
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ccaption_dec: clarify log message when out-of-display columns are ignored
2024-03-09 18:39 [FFmpeg-devel] [PATCH 1/2] avcodec/ccaption_dec: clarify log message when out-of-display columns are ignored Marth64
2024-03-09 18:39 ` [FFmpeg-devel] [PATCH 2/2] avcodec/ccaption_dec: use consistent naming convention of Closed Captions Marth64
@ 2024-03-10 14:11 ` Stefano Sabatini
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Sabatini @ 2024-03-10 14:11 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Marth64
On date Saturday 2024-03-09 12:39:55 -0600, Marth64 wrote:
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
> libavcodec/ccaption_dec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c
> index 1550e4b253..d03413265a 100644
> --- a/libavcodec/ccaption_dec.c
> +++ b/libavcodec/ccaption_dec.c
> @@ -358,7 +358,7 @@ static void write_char(CCaptionSubContext *ctx, struct Screen *screen, char ch)
> return;
> }
> else {
> - av_log(ctx, AV_LOG_WARNING, "Data Ignored since exceeding screen width\n");
> + av_log(ctx, AV_LOG_WARNING, "Data ignored due to columns exceeding screen width\n");
> return;
> }
will apply, thanks
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/2] avcodec/ccaption_dec: use consistent naming convention of Closed Captions
2024-03-09 18:39 ` [FFmpeg-devel] [PATCH 2/2] avcodec/ccaption_dec: use consistent naming convention of Closed Captions Marth64
@ 2024-03-10 14:12 ` Stefano Sabatini
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Sabatini @ 2024-03-10 14:12 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Marth64
On date Saturday 2024-03-09 12:39:56 -0600, Marth64 wrote:
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
> libavcodec/ccaption_dec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c
> index d03413265a..faf058ce97 100644
> --- a/libavcodec/ccaption_dec.c
> +++ b/libavcodec/ccaption_dec.c
> @@ -948,7 +948,7 @@ static const AVOption options[] = {
> };
>
> static const AVClass ccaption_dec_class = {
> - .class_name = "Closed caption Decoder",
> + .class_name = "Closed Captions Decoder",
> .item_name = av_default_item_name,
> .option = options,
> .version = LIBAVUTIL_VERSION_INT,
> @@ -956,7 +956,7 @@ static const AVClass ccaption_dec_class = {
>
> const FFCodec ff_ccaption_decoder = {
> .p.name = "cc_dec",
> - CODEC_LONG_NAME("Closed Caption (EIA-608 / CEA-708)"),
> + CODEC_LONG_NAME("Closed Captions (EIA-608 / CEA-708)"),
> .p.type = AVMEDIA_TYPE_SUBTITLE,
> .p.id = AV_CODEC_ID_EIA_608,
> .p.priv_class = &ccaption_dec_class,
> --
> 2.34.1
Will apply, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-10 14:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-09 18:39 [FFmpeg-devel] [PATCH 1/2] avcodec/ccaption_dec: clarify log message when out-of-display columns are ignored Marth64
2024-03-09 18:39 ` [FFmpeg-devel] [PATCH 2/2] avcodec/ccaption_dec: use consistent naming convention of Closed Captions Marth64
2024-03-10 14:12 ` Stefano Sabatini
2024-03-10 14:11 ` [FFmpeg-devel] [PATCH 1/2] avcodec/ccaption_dec: clarify log message when out-of-display columns are ignored Stefano Sabatini
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git