From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8B74849CA4 for ; Thu, 7 Mar 2024 20:37:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E8DA268CB56; Thu, 7 Mar 2024 22:37:47 +0200 (EET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7496068C7E9 for ; Thu, 7 Mar 2024 22:37:41 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id A6862FF807 for ; Thu, 7 Mar 2024 20:37:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1709843860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DQu+FOnCIq3GAujoUwJYL7KUPDeGLRqv86+Q0Ec9TGc=; b=kGQEuWJKu/SQD2dSK3pHHMiar+pEYprRzUIwPOT/ud3BrKMnpB3SIEX8jJB8EQSNwYOrrL x3MEmigMRkUJXaaF5bDyLAkRAYQpaTH0zwm7sEZ6DW7pIBthTIYU6JTnkccdYqzCloSjVk rjRei02ooIG79w2mSDFM9lJ+tlvRnzmm917lE65G7VCLcqzjp+GPowZI3OGTPIPXs0D3Eu F+YeakFCuUra7LUZT0xIRGuttgNgi+WCyL0WP2PHArGATX9L/z4imuWugItdEvHG4PxHhl sZ7opUSg6YNNopxQvNop8BpSjXKaRish8DdlfPO93O/80Tat7t0+MuUYO6sbDA== Date: Thu, 7 Mar 2024 21:37:39 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240307203739.GI6420@pb2> References: <20240306110319.17339-1-anton@khirnov.net> <20240306110319.17339-2-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20240306110319.17339-2-anton@khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 02/18] fftools/ffmpeg_filter: refactor setting input timebase X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3167754794521967351==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3167754794521967351== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="InFK976ZzVhTba+t" Content-Disposition: inline --InFK976ZzVhTba+t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 06, 2024 at 12:03:03PM +0100, Anton Khirnov wrote: > Treat it analogously to stream parameters like format/dimensions/etc. > This is functionally different from previous code in 2 ways: > * for non-CFR video, the frame timebase (set by the decoder) is used > rather than the demuxer timebase > * for sub2video, AV_TIME_BASE_Q is used, which is hardcoded by the > subtitle decoding API >=20 > These changes should avoid unnecessary and potentially lossy timestamp > conversions from decoder timebase into the demuxer one. >=20 > Changes the timebases used in sub2video tests. > --- > fftools/ffmpeg_filter.c | 17 ++- > tests/ref/fate/sub2video_basic | 182 +++++++++++++------------- > tests/ref/fate/sub2video_time_limited | 8 +- > 3 files changed, 106 insertions(+), 101 deletions(-) breaks: =2E/ffmpeg -i \[a-s\]_full_metal_panic_fumoffu_-_01_-_the_man_from_the_sout= h_-_a_hostage_with_no_compromises__rs2_\[1080p_bd-rip\]\[BBB48A25\].mkv -f= ilter_complex '[0:s:1]scale=3D800:600' -t 15 -qscale 2 -y a.avi Press [q] to stop, [?] for help [aac @ 0x561991f96340] This stream seems to incorrectly report its last cha= nnel as LFE[3], mapping to LFE[0] [mpeg4 @ 0x561991f7e440] timebase 1/1000000 not supported by MPEG 4 standar= d, the maximum admitted value for the timebase denominator is 65535 [vost#0:0/mpeg4 @ 0x561991f78f80] Error while opening encoder - maybe incor= rect parameters such as bit_rate, rate, width or height. [fc#0 @ 0x561991f4b9c0] Error sending frames to consumers: Invalid argument [fc#0 @ 0x561991f4b9c0] Task finished with error code: -22 (Invalid argumen= t) [fc#0 @ 0x561991f4b9c0] Terminating thread with return code -22 (Invalid ar= gument) [vost#0:0/mpeg4 @ 0x561991f78f80] Could not open encoder before EOF [vost#0:0/mpeg4 @ 0x561991f78f80] Task finished with error code: -22 (Inval= id argument) [vost#0:0/mpeg4 @ 0x561991f78f80] Terminating thread with return code -22 (= Invalid argument) [libmp3lame @ 0x561992064180] Trying to remove 1152 samples, but the queue = is empty [out#0/avi @ 0x561991f98bc0] Nothing was written into output file, because = at least one of its streams received no packets. frame=3D 0 fps=3D0.0 q=3D0.0 Lsize=3D 0KiB time=3DN/A bitrate=3DN/= A speed=3DN/A Conversion failed! ill try to find a smaller testcase thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Elect your leaders based on what they did after the last election, not based on what they say before an election. --InFK976ZzVhTba+t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZeoliwAKCRBhHseHBAsP q27nAJ9z2stO8B1pPFPhLNU9gAyMmYSUsgCeNF56VSwbPkvRqmbIVmj0l6DuHVw= =0nEJ -----END PGP SIGNATURE----- --InFK976ZzVhTba+t-- --===============3167754794521967351== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3167754794521967351==--