* [FFmpeg-devel] [PATCH] lavfi/vulkan_filter: fix input format
@ 2024-03-06 5:25 Xiang, Haihao
2024-03-07 4:05 ` Lynne
0 siblings, 1 reply; 3+ messages in thread
From: Xiang, Haihao @ 2024-03-06 5:25 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Haihao Xiang
From: Haihao Xiang <haihao.xiang@intel.com>
Otherwise s->input_format is always yuv420p.
This fixes invalid output format for hwframe download in the command
below:
./ffmpeg -init_hw_device vulkan -f lavfi \
-i testsrc=duration=1,format=nv12 \
-vf 'hwupload,format=vulkan,scale_vulkan=1024:768,hwdownload,format=nv12' \
-f null -
Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
---
libavfilter/vulkan_filter.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavfilter/vulkan_filter.c b/libavfilter/vulkan_filter.c
index d3dc2fdacb..cef42eeb4d 100644
--- a/libavfilter/vulkan_filter.c
+++ b/libavfilter/vulkan_filter.c
@@ -187,6 +187,7 @@ int ff_vk_filter_config_input(AVFilterLink *inlink)
s->input_frames_ref = inlink->hw_frames_ctx;
/* Defaults */
+ s->input_format = input_frames->sw_format;
s->output_format = input_frames->sw_format;
s->output_width = inlink->w;
s->output_height = inlink->h;
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavfi/vulkan_filter: fix input format
2024-03-06 5:25 [FFmpeg-devel] [PATCH] lavfi/vulkan_filter: fix input format Xiang, Haihao
@ 2024-03-07 4:05 ` Lynne
2024-03-08 2:14 ` Xiang, Haihao
0 siblings, 1 reply; 3+ messages in thread
From: Lynne @ 2024-03-07 4:05 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Mar 6, 2024, 06:26 by haihao.xiang-at-intel.com@ffmpeg.org:
> From: Haihao Xiang <haihao.xiang@intel.com>
>
> Otherwise s->input_format is always yuv420p.
>
> This fixes invalid output format for hwframe download in the command
> below:
> ./ffmpeg -init_hw_device vulkan -f lavfi \
> -i testsrc=duration=1,format=nv12 \
> -vf 'hwupload,format=vulkan,scale_vulkan=1024:768,hwdownload,format=nv12' \
> -f null -
>
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> ---
> libavfilter/vulkan_filter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavfilter/vulkan_filter.c b/libavfilter/vulkan_filter.c
> index d3dc2fdacb..cef42eeb4d 100644
> --- a/libavfilter/vulkan_filter.c
> +++ b/libavfilter/vulkan_filter.c
> @@ -187,6 +187,7 @@ int ff_vk_filter_config_input(AVFilterLink *inlink)
> s->input_frames_ref = inlink->hw_frames_ctx;
>
> /* Defaults */
> + s->input_format = input_frames->sw_format;
> s->output_format = input_frames->sw_format;
> s->output_width = inlink->w;
> s->output_height = inlink->h;
>
LGTM
Thanks
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavfi/vulkan_filter: fix input format
2024-03-07 4:05 ` Lynne
@ 2024-03-08 2:14 ` Xiang, Haihao
0 siblings, 0 replies; 3+ messages in thread
From: Xiang, Haihao @ 2024-03-08 2:14 UTC (permalink / raw)
To: ffmpeg-devel
On Do, 2024-03-07 at 05:05 +0100, Lynne wrote:
> Mar 6, 2024, 06:26 by haihao.xiang-at-intel.com@ffmpeg.org:
>
> > From: Haihao Xiang <haihao.xiang@intel.com>
> >
> > Otherwise s->input_format is always yuv420p.
> >
> > This fixes invalid output format for hwframe download in the command
> > below:
> > ./ffmpeg -init_hw_device vulkan -f lavfi \
> > -i testsrc=duration=1,format=nv12 \
> > -vf 'hwupload,format=vulkan,scale_vulkan=1024:768,hwdownload,format=nv12' \
> > -f null -
> >
> > Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> > ---
> > libavfilter/vulkan_filter.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/libavfilter/vulkan_filter.c b/libavfilter/vulkan_filter.c
> > index d3dc2fdacb..cef42eeb4d 100644
> > --- a/libavfilter/vulkan_filter.c
> > +++ b/libavfilter/vulkan_filter.c
> > @@ -187,6 +187,7 @@ int ff_vk_filter_config_input(AVFilterLink *inlink)
> > s->input_frames_ref = inlink->hw_frames_ctx;
> >
> > /* Defaults */
> > + s->input_format = input_frames->sw_format;
> > s->output_format = input_frames->sw_format;
> > s->output_width = inlink->w;
> > s->output_height = inlink->h;
> >
>
> LGTM
> Thanks
Thanks for reviewing the patch, pushed.
BRs
Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-08 2:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-06 5:25 [FFmpeg-devel] [PATCH] lavfi/vulkan_filter: fix input format Xiang, Haihao
2024-03-07 4:05 ` Lynne
2024-03-08 2:14 ` Xiang, Haihao
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git