Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/parser: merge packets from the same frame

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Andriy Gelman <andriy.gelman@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/parser: merge packets from the same frame
Date: Tue, 5 Mar 2024 21:51:56 +0100
Message-ID: <20240305205156.GB6420@pb2> (raw)
In-Reply-To: <MR1P264MB248371344369AD1227A37CB99B232@MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM>

[-- Attachment #1.1: Type: text/plain, Size: 1741 bytes --]

Hi

On Mon, Mar 04, 2024 at 05:38:48PM +0000, Nicolas Gaullier wrote:
> >De : ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> De la part de Michael Niedermayer
> >Envoyé : dimanche 3 mars 2024 23:07
> >À : FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> >Objet : Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/parser: merge packets from the same frame
> >
> >On Fri, Mar 01, 2024 at 02:39:19PM +0100, Nicolas Gaullier wrote:
> >> The mpegts demuxer splits packets according to its max_packet_size.
> >> This currently fills the AVCodecParserContext s->cur_frame_* arrays 
> >> with kind of 'empty' entries: no pts/dts.
> >> This patch merges these entries, so the parser behaviour is 
> >> independent from the demuxer settings.
> >> This patch is required for the following patch which will fetch 'past'
> >> timestamps from past cur_frames.
> >> 
> >> Signed-off-by: Nicolas Gaullier <nicolas.gaullier@cji.paris>
> >> ---
> >>  libavcodec/parser.c | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >
> >Breaks fate-seek-lavf-as
> 
> Really sorry about that, I was not aware that assert-level=2 had to be enabled to get full fate tests.
> Maybe this should be documented in the fate.texi.

patch welcome

> I also checked the green light on patchwork... It seems at least assert-level=1 is not supposed to consume too much cpu, so maybe it could be enabled for patchwork?

CCing Andriy

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".