From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6484B49B76 for ; Sun, 3 Mar 2024 22:07:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3716968D197; Mon, 4 Mar 2024 00:07:00 +0200 (EET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1707768D197 for ; Mon, 4 Mar 2024 00:06:53 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4BFF140002 for ; Sun, 3 Mar 2024 22:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1709503612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/bEewzT1IoJw8phBmskjzor3F/tA36GIlnaAdlvZn9E=; b=KNj71ZxKbt4HZOKXlL7rgcJOIl7AvZpar5og+PJy8kXQpCUyyMwW2+aWBGnWFagx/yLIT0 RKSroeAm7mTOgMq/b1rajAV4Q93GlBe1F8R+CeHpUWsjVxZHseAm0xv7ECFMmOpTZSCpWj nUf+oS9qKWmLmoFjye0qbcT//kHv9tiy4Bivc7pAWBAaWW/ShQoUy76sOGTTMTMD9k0kXN aHtL0Qerrcrz1YA1Z55Ds3n+nbApqcqT6HjANYZPdmQu04VX6D/G/vh3VQj97ulktY8cl3 alQCyd8LtHummuzlA+EAYhbc9UxKHc/YaLoj5UGKz183Ms/x6dO8YcFPKUr4vQ== Date: Sun, 3 Mar 2024 23:06:51 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240303220651.GS6420@pb2> References: <20240301133923.1132924-1-nicolas.gaullier@cji.paris> <20240301133923.1132924-2-nicolas.gaullier@cji.paris> MIME-Version: 1.0 In-Reply-To: <20240301133923.1132924-2-nicolas.gaullier@cji.paris> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/parser: merge packets from the same frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8770790220115687117==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8770790220115687117== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tbbOQpz61gbgmdvu" Content-Disposition: inline --tbbOQpz61gbgmdvu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 01, 2024 at 02:39:19PM +0100, Nicolas Gaullier wrote: > The mpegts demuxer splits packets according to its max_packet_size. > This currently fills the AVCodecParserContext s->cur_frame_* arrays with > kind of 'empty' entries: no pts/dts. > This patch merges these entries, so the parser behaviour is independent > from the demuxer settings. > This patch is required for the following patch which will fetch 'past' > timestamps from past cur_frames. >=20 > Signed-off-by: Nicolas Gaullier > --- > libavcodec/parser.c | 4 ++++ > 1 file changed, 4 insertions(+) Breaks fate-seek-lavf-as --- ./tests/ref/seek/lavf-asf 2024-02-28 23:42:14.743496132 +0100 +++ tests/data/fate/seek-lavf-asf 2024-03-03 23:06:08.850893410 +0100 @@ -1,53 +0,0 @@ -ret: 0 st: 1 flags:1 dts: 0.000000 pts: 0.000000 pos: 693 size:= 208 -ret: 0 st:-1 flags:0 ts:-1.000000 -ret: 0 st: 1 flags:1 dts: 0.000000 pts: 0.000000 pos: 693 size:= 208 -ret: 0 st:-1 flags:1 ts: 1.894167 -ret: 0 st: 1 flags:1 dts: 0.470000 pts: 0.470000 pos: 147893 size:= 209 -ret: 0 st: 0 flags:0 ts: 0.788000 -ret: 0 st: 1 flags:1 dts: 0.470000 pts: 0.470000 pos: 147893 size:= 209 -ret: 0 st: 0 flags:1 ts:-0.317000 -ret: 0 st: 1 flags:1 dts: 0.000000 pts: 0.000000 pos: 693 size:= 208 -ret: 0 st: 1 flags:0 ts: 2.577000 -ret: 0 st: 1 flags:1 dts: 0.993000 pts: 0.993000 pos: 330293 size:= 209 -ret: 0 st: 1 flags:1 ts: 1.471000 -ret: 0 st: 1 flags:1 dts: 0.993000 pts: 0.993000 pos: 330293 size:= 209 -ret: 0 st:-1 flags:0 ts: 0.365002 -ret: 0 st: 1 flags:1 dts: 0.470000 pts: 0.470000 pos: 147893 size:= 209 -ret: 0 st:-1 flags:1 ts:-0.740831 -ret: 0 st: 1 flags:1 dts: 0.000000 pts: 0.000000 pos: 693 size:= 208 -ret: 0 st: 0 flags:0 ts: 2.153000 -ret: 0 st: 1 flags:1 dts: 0.941000 pts: 0.941000 pos: 301493 size:= 209 -ret: 0 st: 0 flags:1 ts: 1.048000 -ret: 0 st: 1 flags:1 dts: 0.941000 pts: 0.941000 pos: 301493 size:= 209 -ret: 0 st: 1 flags:0 ts:-0.058000 -ret: 0 st: 1 flags:1 dts: 0.000000 pts: 0.000000 pos: 693 size:= 208 -ret: 0 st: 1 flags:1 ts: 2.836000 -ret: 0 st: 1 flags:1 dts: 0.993000 pts: 0.993000 pos: 330293 size:= 209 -ret: 0 st:-1 flags:0 ts: 1.730004 -ret: 0 st: 1 flags:1 dts: 0.941000 pts: 0.941000 pos: 301493 size:= 209 -ret: 0 st:-1 flags:1 ts: 0.624171 -ret: 0 st: 1 flags:1 dts: 0.000000 pts: 0.000000 pos: 693 size:= 208 -ret: 0 st: 0 flags:0 ts:-0.482000 -ret: 0 st: 1 flags:1 dts: 0.000000 pts: 0.000000 pos: 693 size:= 208 -ret: 0 st: 0 flags:1 ts: 2.413000 -ret: 0 st: 1 flags:1 dts: 0.941000 pts: 0.941000 pos: 301493 size:= 209 -ret: 0 st: 1 flags:0 ts: 1.307000 -ret: 0 st: 1 flags:1 dts: 0.993000 pts: 0.993000 pos: 330293 size:= 209 -ret: 0 st: 1 flags:1 ts: 0.201000 -ret: 0 st: 1 flags:1 dts: 0.000000 pts: 0.000000 pos: 693 size:= 208 -ret: 0 st:-1 flags:0 ts:-0.904994 -ret: 0 st: 1 flags:1 dts: 0.000000 pts: 0.000000 pos: 693 size:= 208 -ret: 0 st:-1 flags:1 ts: 1.989173 -ret: 0 st: 1 flags:1 dts: 0.941000 pts: 0.941000 pos: 301493 size:= 209 -ret: 0 st: 0 flags:0 ts: 0.883000 -ret: 0 st: 1 flags:1 dts: 0.470000 pts: 0.470000 pos: 147893 size:= 209 -ret: 0 st: 0 flags:1 ts:-0.222000 -ret: 0 st: 1 flags:1 dts: 0.000000 pts: 0.000000 pos: 693 size:= 208 -ret: 0 st: 1 flags:0 ts: 2.672000 -ret: 0 st: 1 flags:1 dts: 0.993000 pts: 0.993000 pos: 330293 size:= 209 -ret: 0 st: 1 flags:1 ts: 1.566000 -ret: 0 st: 1 flags:1 dts: 0.993000 pts: 0.993000 pos: 330293 size:= 209 -ret: 0 st:-1 flags:0 ts: 0.460008 -ret: 0 st: 1 flags:1 dts: 0.470000 pts: 0.470000 pos: 147893 size:= 209 -ret: 0 st:-1 flags:1 ts:-0.645825 -ret: 0 st: 1 flags:1 dts: 0.000000 pts: 0.000000 pos: 693 size:= 208 Test seek-lavf-asf failed. Look at tests/data/fate/seek-lavf-asf.err for de= tails. [asf @ 0x5623c91f8280] asf_read_pts failed [asf @ 0x5623c91f8280] asf_read_pts failed [asf @ 0x5623c91f8280] asf_read_pts failed [asf @ 0x5623c91f8280] asf_read_pts failed [asf @ 0x5623c91f8280] asf_read_pts failed [asf @ 0x5623c91f8280] asf_read_pts failed [asf @ 0x5623c91f8280] asf_read_pts failed [asf @ 0x5623c91f8280] asf_read_pts failed Assertion pkt->pos =3D=3D asf_st->packet_pos failed at libavformat/asfdec_f= =2Ec:1478 Aborted (core dumped) threads=3D1 tests/Makefile:318: recipe for target 'fate-seek-lavf-asf' failed make: *** [fate-seek-lavf-asf] Error 134 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When the tyrant has disposed of foreign enemies by conquest or treaty, and there is nothing more to fear from them, then he is always stirring up some war or other, in order that the people may require a leader. -- Plato --tbbOQpz61gbgmdvu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZeT0dQAKCRBhHseHBAsP q9l8AJ9hfgx9Z/eaMJhMssMWj3sVtqp2pQCeL0dRDFPbt1gY89sdT6Mfmb0OUpk= =5APh -----END PGP SIGNATURE----- --tbbOQpz61gbgmdvu-- --===============8770790220115687117== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8770790220115687117==--