From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F171049091 for ; Sun, 3 Mar 2024 01:02:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 924D568D327; Sun, 3 Mar 2024 03:02:46 +0200 (EET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2AA7D68CBD3 for ; Sun, 3 Mar 2024 03:02:40 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5D53FFF803 for ; Sun, 3 Mar 2024 01:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1709427759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aeS2jSUAmx+SQLRgQJF2qZkWsoiG3aE3U1GKK3kaXGw=; b=n0Q8cK5mqGAIKnisM2qfC6rQvinVRWgvlqzfvCxstXbEW47YyCwjN1ioeM/RyODwGfhd3N sRybyzG+0prMoHvLxhikq8aFagJIJn4jExwkUmmzk9ye4QS6qoyISc9Cja2BSlsgPdEP8F N0HcU/KP5rhf9i5wbvAKhEIgOid1kYc2+F24osc/AzLbuGxWveq2OqBJ8/Z+L1rHYh6qja iBW7CObwWOkJeQ6Q+1mrIHgfa+c4fPBTg6nEjO4UPxfqTVeNrtmEwUu8hECLBrfEkjFvnx gI1vsUH9W5JtD5e6zNkdHT5q9spPsZmbdTKRIO7DP7CTuf43ruNeVuQs/Otgxg== Date: Sun, 3 Mar 2024 02:02:38 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240303010238.GL6420@pb2> References: <20240229174122.6696-1-jamrial@gmail.com> <20240229174122.6696-2-jamrial@gmail.com> <20240303002756.GK6420@pb2> <3c12598e-4bf5-4a17-8a53-1cf08b244e82@gmail.com> MIME-Version: 1.0 In-Reply-To: <3c12598e-4bf5-4a17-8a53-1cf08b244e82@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/iamfenc: ensure updated extradata is written X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5064016597368907925==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5064016597368907925== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rVY/BM9G5eitqENh" Content-Disposition: inline --rVY/BM9G5eitqENh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 02, 2024 at 09:31:09PM -0300, James Almer wrote: > On 3/2/2024 9:27 PM, Michael Niedermayer wrote: > > On Thu, Feb 29, 2024 at 02:41:22PM -0300, James Almer wrote: > > > Signed-off-by: James Almer > > > --- > > > libavformat/iamfenc.c | 30 +++++++++++++++++++++++++++++- > > > tests/ref/fate/iamf-5_1_4 | 14 +++++++------- > > > tests/ref/fate/iamf-7_1_4 | 16 ++++++++-------- > > > tests/ref/fate/iamf-ambisonic_1 | 10 +++++----- > > > tests/ref/fate/iamf-stereo | 4 ++-- > > > 5 files changed, 51 insertions(+), 23 deletions(-) > >=20 > > seems to break fate here > >=20 > > --- ./tests/ref/fate/iamf-7_1_4 2024-03-03 01:24:48.462539621 +0100 > > +++ tests/data/fate/iamf-7_1_4 2024-03-03 01:25:31.762992374 +0100 > > @@ -1,12 +1,12 @@ > > -5d9fcee2b9b2ad3c802c40bb1147016e *tests/data/fate/iamf-7_1_4.iamf > > +157c3185684e12cc8385ee7c3ef2fb4c *tests/data/fate/iamf-7_1_4.iamf > > 99851 tests/data/fate/iamf-7_1_4.iamf > > -#extradata 0: 34, 0xafa70d5e > > -#extradata 1: 34, 0xafa70d5e > > -#extradata 2: 34, 0xaf7b0d5c > > -#extradata 3: 34, 0xaf7b0d5c > > -#extradata 4: 34, 0xafa70d5e > > -#extradata 5: 34, 0xafa70d5e > > -#extradata 6: 34, 0xafa70d5e > > +#extradata 0: 34, 0x40a802c6 > > +#extradata 1: 34, 0x40a802c6 > > +#extradata 2: 34, 0x407c02c4 > > +#extradata 3: 34, 0x407c02c4 > > +#extradata 4: 34, 0x40a802c6 > > +#extradata 5: 34, 0x40a802c6 > > +#extradata 6: 34, 0x40a802c6 > > #tb 0: 1/44100 > > #media_type 0: audio > > #codec_id 0: flac >=20 > Did you apply the first patch before this one? I thought i did, but i retested with a clean branch and with that it passes thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way around the laws. -- Plato --rVY/BM9G5eitqENh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZePMJAAKCRBhHseHBAsP q9j+AJ49dboW/pGzGTulOURnRo6F4ALbhgCghVhFSWi1SiXjBCLcMddbf0EnwtI= =7fk+ -----END PGP SIGNATURE----- --rVY/BM9G5eitqENh-- --===============5064016597368907925== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5064016597368907925==--