From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E9D1D48FE7 for ; Sun, 3 Mar 2024 00:28:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7D93E68D325; Sun, 3 Mar 2024 02:28:04 +0200 (EET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3EA9B68BA2D for ; Sun, 3 Mar 2024 02:27:58 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id EE0641BF203 for ; Sun, 3 Mar 2024 00:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1709425677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YZVke0/2TNx/Cep00D6tySOqMNH8sCxSJrsLEDS33wQ=; b=G97SpsdzWNddh1z7UzqZPt5tMot+W7wl/0kJN7kvmJ0/qt9+NQepLiwTWZW/kLoTC+4C5s ExPuk9wyN5qU5QkpLHl0w7XDNrvx9A9HUe3+h70u30lRtvy1jFiuzcnA1LCVfTYijhssj6 CkhbXySfYu0ZJxMNJG4jc8fKiOqIkSr44fCgpHJRpXZfsaCROUB2TJaVgOVOtByiw/BSX/ HmwZHORyDKMKtn5/ML8JfWOscGF0E8dNYvccgjISq0lxEu55XazH2PEWgEkBbGrwRsAxuW q8XWx1EWOc6X96/Kc7C3u31N1l/UwHTWmBvl5ED02Uszy3j7z+hnixJz4z0ZNQ== Date: Sun, 3 Mar 2024 01:27:56 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240303002756.GK6420@pb2> References: <20240229174122.6696-1-jamrial@gmail.com> <20240229174122.6696-2-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20240229174122.6696-2-jamrial@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/iamfenc: ensure updated extradata is written X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4361219648718163012==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4361219648718163012== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kaWTYy5y3TGBSzbR" Content-Disposition: inline --kaWTYy5y3TGBSzbR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 29, 2024 at 02:41:22PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/iamfenc.c | 30 +++++++++++++++++++++++++++++- > tests/ref/fate/iamf-5_1_4 | 14 +++++++------- > tests/ref/fate/iamf-7_1_4 | 16 ++++++++-------- > tests/ref/fate/iamf-ambisonic_1 | 10 +++++----- > tests/ref/fate/iamf-stereo | 4 ++-- > 5 files changed, 51 insertions(+), 23 deletions(-) seems to break fate here --- ./tests/ref/fate/iamf-7_1_4 2024-03-03 01:24:48.462539621 +0100 +++ tests/data/fate/iamf-7_1_4 2024-03-03 01:25:31.762992374 +0100 @@ -1,12 +1,12 @@ -5d9fcee2b9b2ad3c802c40bb1147016e *tests/data/fate/iamf-7_1_4.iamf +157c3185684e12cc8385ee7c3ef2fb4c *tests/data/fate/iamf-7_1_4.iamf 99851 tests/data/fate/iamf-7_1_4.iamf -#extradata 0: 34, 0xafa70d5e -#extradata 1: 34, 0xafa70d5e -#extradata 2: 34, 0xaf7b0d5c -#extradata 3: 34, 0xaf7b0d5c -#extradata 4: 34, 0xafa70d5e -#extradata 5: 34, 0xafa70d5e -#extradata 6: 34, 0xafa70d5e +#extradata 0: 34, 0x40a802c6 +#extradata 1: 34, 0x40a802c6 +#extradata 2: 34, 0x407c02c4 +#extradata 3: 34, 0x407c02c4 +#extradata 4: 34, 0x40a802c6 +#extradata 5: 34, 0x40a802c6 +#extradata 6: 34, 0x40a802c6 #tb 0: 1/44100 #media_type 0: audio #codec_id 0: flac --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place to spit but his face. -- Diogenes of Sinope --kaWTYy5y3TGBSzbR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZePEBgAKCRBhHseHBAsP q2EiAJ9LGFZBLyCmn410JEUwfW2YP28toQCfavnf2YN1DByGWoN5qQvRCxpTRik= =PrVN -----END PGP SIGNATURE----- --kaWTYy5y3TGBSzbR-- --===============4361219648718163012== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4361219648718163012==--