From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A400C48F3E for ; Fri, 1 Mar 2024 01:24:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4A7A368D1F6; Fri, 1 Mar 2024 03:24:45 +0200 (EET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C22FA68CC83 for ; Fri, 1 Mar 2024 03:24:38 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 03F55240002 for ; Fri, 1 Mar 2024 01:24:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1709256278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Iy1/gutl+1BLaGLeGojL4fI26+QCMELsYIKZ9h+XTcY=; b=d38D83Nb4HP7YxjDwzHnpTHY7uVuMjtpWiuC5eocuVtzicy6rRDaiG5yxCOtGGyYE2vH1q 2a45XB1gw3S+6Hu0WnEdVZlcklMnRqtAurp5rFjoGjRlEptcE4Yn6zl0u4PrDiICU22b97 gT2tfIFaMJR/AtI1hAtI+vUhCFAsmGmrWJQaLtfl8kEbH1ShrP325DUI0Ho3Pe+6LRhVhM ZotbL4EM6C7un2vQD6K7gHFT/GXgX2Oi54HgUqx/Chtx61z1XfpNpU+xZ0qS1mNc0qFqLW BZzbEDda2ecKAnPJCQ8wufgecjyFGMS6dHI/Fj9b87Ekrzoqsknb4KZemzOHOw== Date: Fri, 1 Mar 2024 02:24:37 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240301012437.GG6420@pb2> References: <20240229124706.524355-1-jdek@itanimul.li> MIME-Version: 1.0 In-Reply-To: <20240229124706.524355-1-jdek@itanimul.li> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avcodec: deprecate sonic X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6592909739577044160==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6592909739577044160== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gLT9HyTxi0rBm0Rb" Content-Disposition: inline --gLT9HyTxi0rBm0Rb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 29, 2024 at 01:47:06PM +0100, J. Dekker wrote: > This is an experimental and research codec of which ffmpeg is the only > encoder and decoder, development has stalled since 2013 and these files > don't exist in the wild. >=20 > Deprecate the encoders to be removed next major bump, decoders to be > removed one bump afterwards. We also disable the the encoders by default > in configure, the decoders should be disabled by default next bump. >=20 > Signed-off-by: J. Dekker > --- >=20 > Since this codec was added in 2004, there has only been one major > non-maintenance, non-bugfix commit in 2013 (6026a5ad4f). That's 1 out of= 107 > total commits touching this file. >=20 > This isn't a matter of the codec being unpopular like a niche game codec= or > some other codec with media found in the wild, it's an experiment which = didn't > continue and we continue to pay the maintenance cost. >=20 > Deprecating the codec instead of immediate removal gives a grace period = for > anyone interested to pick up the format and make it the most advanced au= dio > codec in FFmpeg if they so wish. It encourages an action to be taken whe= ther > that be improving the codec, or leaving it to be removed later. >=20 > configure | 3 +++ > libavcodec/version_major.h | 4 ++++ > 2 files changed, 7 insertions(+) >=20 > diff --git a/configure b/configure > index bb5e630bad..f11c035796 100755 > --- a/configure > +++ b/configure > @@ -4234,6 +4234,9 @@ do_random(){ > $action $(rand_list "$@" | awk "BEGIN { srand($random_seed) } \$1 = =3D=3D \"prob\" { prob =3D \$2; next } rand() < prob { print }") > } > =20 > +# deprecated components (disabled by default) > +disable sonic_encoder sonic_ls_encoder > + > for opt do > optval=3D"${opt#*=3D}" > case "$opt" in > diff --git a/libavcodec/version_major.h b/libavcodec/version_major.h > index 161442df95..97e4c47d45 100644 > --- a/libavcodec/version_major.h > +++ b/libavcodec/version_major.h > @@ -57,5 +57,9 @@ > =20 > // reminder to remove CrystalHD decoders on next major bump > #define FF_CODEC_CRYSTAL_HD (LIBAVCODEC_VERSION_MAJOR < 61) > +// reminder to remove Sonic Lossy/Lossless encoders on next major bump > +#define FF_CODEC_SONIC_ENC (LIBAVCODEC_VERSION_MAJOR < 62) > +// reminder to remove Sonic decoder on next-next major bump > +#define FF_CODEC_SONIC_DEC (LIBAVCODEC_VERSION_MAJOR < 63) id like to ask for a later deadline (or no deadline) because if we get accepted by STF, i will have many things to do this year and developing a new codec disimilar to existing codecs in FFmpeg will not be possible in 2024 in parallel to STF thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong. --gLT9HyTxi0rBm0Rb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZeEuUQAKCRBhHseHBAsP qyLiAJ0QdyHfeeMCQ82PVb34FkbTMr1JKQCfZgE3pe82tm194eOdZMrdqrReq4E= =gtPA -----END PGP SIGNATURE----- --gLT9HyTxi0rBm0Rb-- --===============6592909739577044160== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6592909739577044160==--