From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 190D747ACF
	for <ffmpegdev@gitmailbox.com>; Thu, 29 Feb 2024 12:43:48 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6609868CED2;
	Thu, 29 Feb 2024 14:43:45 +0200 (EET)
Received: from haasn.dev (haasn.dev [78.46.187.166])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DB31568CC25
 for <ffmpeg-devel@ffmpeg.org>; Thu, 29 Feb 2024 14:43:38 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail;
 t=1709210618; bh=DYc7aMvX/BGkKbkgvZQOXcH+/jRzEGWcmI2zhJ4UwmU=;
 h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
 b=tm4IN2j5SeptJJiVdVJ9Uu/kGKJcdr1zchJUQoZR5rfV4o3CXL/4TXbcbyOK4QkH4
 Sug6IZB1DWhKQWP2DDQDoSf3LaT1z0iQ/ysfafmfRi+0sUK4cgXpP+lVHCv/yMrmBm
 5EZHviyQ5czaZ3u99I7gltM3qfGNm7V+/WwSHJwg=
Received: from haasn.dev (unknown [10.30.0.2])
 by haasn.dev (Postfix) with ESMTP id 97BFF40292;
 Thu, 29 Feb 2024 13:43:38 +0100 (CET)
Date: Thu, 29 Feb 2024 13:43:38 +0100
Message-ID: <20240229134338.GB51236@haasn.xyz>
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
In-Reply-To: <20240229123340.49055-2-ffmpeg@haasn.xyz>
References: <20240229123340.49055-2-ffmpeg@haasn.xyz>
MIME-Version: 1.0
Content-Disposition: inline
Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/aom_film_grain: add AOM
 film grain synthesis
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Niklas Haas <git@haasn.dev>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20240229134338.GB51236@haasn.xyz/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Thu, 29 Feb 2024 13:33:36 +0100 Niklas Haas <ffmpeg@haasn.xyz> wrote:
> +// Symbols that do not depend on bit depth
> +#ifndef GRAIN_WIDTH
> +# define GRAIN_WIDTH 82
> +# define GRAIN_HEIGHT 73
> +# define SUB_GRAIN_WIDTH 44
> +# define SUB_GRAIN_HEIGHT 38
> +# define FG_BLOCK_SIZE 32
> +#endif

Decided to move these out of this template as well.

At what point would it be cleaner to introduce an
<aom_film_grain_internal.h> just for these shared helpers / definitions
live inside?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".