From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 2D82B48ED5
	for <ffmpegdev@gitmailbox.com>; Thu, 29 Feb 2024 12:18:57 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8DD4268CFE5;
	Thu, 29 Feb 2024 14:18:55 +0200 (EET)
Received: from haasn.dev (haasn.dev [78.46.187.166])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 198E468C92E
 for <ffmpeg-devel@ffmpeg.org>; Thu, 29 Feb 2024 14:18:49 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail;
 t=1709209128; bh=267o01emYvlPgxNgGzTLP8DNX2QrOMzFXto/QyjL0k8=;
 h=Date:From:To:Subject:In-Reply-To:References:From;
 b=bofAkxB1Ice0BKGn7B8yujc4YmDp6IXKVuOYdFKc6sjUE1LCpnfVCRflraOFnTSiU
 lNmt4mbm/p07VQODx/vp8g2tFUGazI561QsjeNO5V9Jkx5AfmKdsMs9t/znxWeDOJw
 vml7cC9HQTTEWaBRt8MygXUoA2CokczCPCfy3ByI=
Received: from haasn.dev (unknown [10.30.0.2])
 by haasn.dev (Postfix) with ESMTP id DB9FB40292
 for <ffmpeg-devel@ffmpeg.org>; Thu, 29 Feb 2024 13:18:48 +0100 (CET)
Date: Thu, 29 Feb 2024 13:18:48 +0100
Message-ID: <20240229131848.GB44036@haasn.xyz>
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
In-Reply-To: <AS8P250MB0744AC9D5A8E0C82573E0F738F5F2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
References: <20240226143521.57913-1-ffmpeg@haasn.xyz>
 <AS8P250MB07444A6DC45286BA843A5A198F582@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
 <20240228165605.GB85477@haasn.xyz>
 <AS8P250MB0744062D1E907C579288E0FB8F582@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
 <20240229120301.GB20801@haasn.xyz>
 <AS8P250MB0744AC9D5A8E0C82573E0F738F5F2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Disposition: inline
Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add AOM film
 grain synthesis
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20240229131848.GB44036@haasn.xyz/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Thu, 29 Feb 2024 12:52:58 +0100 Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
> Niklas Haas:
> > +    av_assert0(out_frame->format == in_frame->format);
> 
> You already asserted that generically at the start of
> ff_aom_apply_film_grain().

Fixed.

> > +    if (in_frame->format != AV_PIX_FMT_YUV420P10LE)
> > +        return AVERROR_PATCHWELCOME;
> 
> wtf! This makes the whole code pointless on BE and makes the 8 bit
> version pointless, too.

Yikes, this was clearly left over from before I made this code generic!
Fixed.

(Doesn't help that I have no other test files for this code..)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".