From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add AOM film grain synthesis
Date: Thu, 29 Feb 2024 13:18:48 +0100
Message-ID: <20240229131848.GB44036@haasn.xyz> (raw)
In-Reply-To: <AS8P250MB0744AC9D5A8E0C82573E0F738F5F2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On Thu, 29 Feb 2024 12:52:58 +0100 Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
> Niklas Haas:
> > + av_assert0(out_frame->format == in_frame->format);
>
> You already asserted that generically at the start of
> ff_aom_apply_film_grain().
Fixed.
> > + if (in_frame->format != AV_PIX_FMT_YUV420P10LE)
> > + return AVERROR_PATCHWELCOME;
>
> wtf! This makes the whole code pointless on BE and makes the 8 bit
> version pointless, too.
Yikes, this was clearly left over from before I made this code generic!
Fixed.
(Doesn't help that I have no other test files for this code..)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-02-29 12:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 14:35 Niklas Haas
2024-02-26 14:35 ` [FFmpeg-devel] [PATCH 2/4] avcodec/aom_film_grain: implement AFGS1 Niklas Haas
2024-02-26 14:35 ` [FFmpeg-devel] [PATCH 3/4] avcodec/h2645_sei: decode AFGS1 T.35 SEI Niklas Haas
2024-02-26 14:35 ` [FFmpeg-devel] [PATCH 4/4] avcodec/hevcdec: apply AOM film grain synthesis Niklas Haas
2024-02-28 15:45 ` [FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add " Andreas Rheinhardt
2024-02-28 15:56 ` Niklas Haas
2024-02-28 16:01 ` Andreas Rheinhardt
2024-02-29 11:03 ` Niklas Haas
2024-02-29 11:36 ` Andreas Rheinhardt
2024-02-29 12:13 ` Niklas Haas
2024-02-29 11:52 ` Andreas Rheinhardt
2024-02-29 12:18 ` Niklas Haas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229131848.GB44036@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git