From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id A9C65471FB
	for <ffmpegdev@gitmailbox.com>; Wed, 28 Feb 2024 15:56:16 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0AA7268CCB2;
	Wed, 28 Feb 2024 17:56:14 +0200 (EET)
Received: from haasn.dev (haasn.dev [78.46.187.166])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2110668C8AC
 for <ffmpeg-devel@ffmpeg.org>; Wed, 28 Feb 2024 17:56:07 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail;
 t=1709135765; bh=zVgJPK4s7ADH401O+TWwUu5UuVwoUl4jhhAeRafe1Dw=;
 h=Date:From:To:Subject:In-Reply-To:References:From;
 b=qMUZB8+JgiXXuZslsOi6uVsj87vFEYF3m+WHgwtvj2L7fI7JGm+Njs+RLak5VSv4h
 MIYVl0fk0aIrTuXeVASxgH1Dp4GeWoWYxKzjWres6EcpsEQtFSA4HNGt4g3SFjdkWn
 Cg4Gpd1UY0KKIRieF1dW+gwEGO5DqJtQj0Ouf+8s=
Received: from haasn.dev (unknown [10.30.0.2])
 by haasn.dev (Postfix) with ESMTP id CFB0D40292
 for <ffmpeg-devel@ffmpeg.org>; Wed, 28 Feb 2024 16:56:05 +0100 (CET)
Date: Wed, 28 Feb 2024 16:56:05 +0100
Message-ID: <20240228165605.GB85477@haasn.xyz>
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
In-Reply-To: <AS8P250MB07444A6DC45286BA843A5A198F582@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
References: <20240226143521.57913-1-ffmpeg@haasn.xyz>
 <AS8P250MB07444A6DC45286BA843A5A198F582@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Disposition: inline
Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add AOM film
 grain synthesis
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20240228165605.GB85477@haasn.xyz/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Wed, 28 Feb 2024 16:45:50 +0100 Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
> I don't think this should be duplicated for every bitdepth.

To clarify, you think the bit depth should be just treated as a runtime
parameter instead of this being a template at all? How would you suggest
to handle the diference in pixel size between 8-bit and 10/12-bit?

Maybe a middle ground would be to compile this template only twice, once
for HBD and once for 8-bit, with the HBD code-path taking the bitdepth
as an extra parameter.

(That's actually what dav1d does internally)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".