From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 065F049ADB for ; Tue, 27 Feb 2024 22:47:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A346C68C865; Wed, 28 Feb 2024 00:47:19 +0200 (EET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1ECB168B02D for ; Wed, 28 Feb 2024 00:47:11 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0FAB5240006 for ; Tue, 27 Feb 2024 22:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1709074030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:in-reply-to:in-reply-to:references:references; bh=EwhzC06EiUg/2vOPx2ieftxJpijU3/KmhazPpb8WUgw=; b=D8HhYY/NJQR/ZJ/MrY5poq5o2QCvdMSZwxT29wqgTLe0ANEGwPSqat4qpMz48Q5S4pVodA gt5fpbC/ekxCvUAaabNpFLvhO4LQi1SwEXNV7qbKDtziOsZb2oDAGPn+NxOtA1OVPfPqnt FPHDZqsl8n+wXNYbv/NBBU3IENo17sAgsxtIoPoTf1XWC5g9nOY6NuIP9Or+dG5jkwcSOA +pzwoPj6BhuzcPAquGBDxCjFa/69sBsv61VNcE4nYq02wBdAHDw5Nec3ImFOCHKhAzHrpI Rt/6+vWSHZ+RMNfT9vfzlIUM2OFahmpjpYiC8bfmCOv+eNy0KQbvUlS0pdn6Mw== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Tue, 27 Feb 2024 23:47:08 +0100 Message-Id: <20240227224708.6883-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240227224708.6883-1-michael@niedermayer.cc> References: <20240227224708.6883-1-michael@niedermayer.cc> X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/vorbisdec: Check remaining data in vorbis_residue_decode_internal() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Fixes: timeout Fixes: 66326/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VORBIS_fuzzer-6295291863040000 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vorbisdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c index faeaeadde7..bf26b13b83 100644 --- a/libavcodec/vorbisdec.c +++ b/libavcodec/vorbisdec.c @@ -1468,6 +1468,9 @@ static av_always_inline int vorbis_residue_decode_internal(vorbis_context *vc, unsigned step = FASTDIV(vr->partition_size << 1, dim << 1); vorbis_codebook codebook = vc->codebooks[vqbook]; + if (get_bits_left(gb) <= 0) + return AVERROR_INVALIDDATA; + if (vr_type == 0) { voffs = voffset+j*vlen; -- 2.17.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".