From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Cc: Niklas Haas <git@haasn.dev>
Subject: [FFmpeg-devel] [PATCH 3/4] avcodec/h2645_sei: decode AFGS1 T.35 SEI
Date: Mon, 26 Feb 2024 15:35:13 +0100
Message-ID: <20240226143521.57913-3-ffmpeg@haasn.xyz> (raw)
In-Reply-To: <20240226143521.57913-1-ffmpeg@haasn.xyz>
From: Niklas Haas <git@haasn.dev>
I restricted this SEI to HEVC for now, until I see a H.264 sample.
---
libavcodec/Makefile | 2 +-
libavcodec/h2645_sei.c | 38 ++++++++++++++++++++++++++++++++++++++
libavcodec/h2645_sei.h | 3 +++
3 files changed, 42 insertions(+), 1 deletion(-)
diff --git a/libavcodec/Makefile b/libavcodec/Makefile
index 09ae5270b38..d86b4018405 100644
--- a/libavcodec/Makefile
+++ b/libavcodec/Makefile
@@ -107,7 +107,7 @@ OBJS-$(CONFIG_H264_SEI) += h264_sei.o h2645_sei.o
OBJS-$(CONFIG_HEVCPARSE) += hevc_parse.o hevc_ps.o hevc_data.o \
h2645data.o h2645_parse.o h2645_vui.o
OBJS-$(CONFIG_HEVC_SEI) += hevc_sei.o h2645_sei.o \
- dynamic_hdr_vivid.o
+ dynamic_hdr_vivid.o aom_film_grain.o
OBJS-$(CONFIG_HPELDSP) += hpeldsp.o
OBJS-$(CONFIG_HUFFMAN) += huffman.o
OBJS-$(CONFIG_HUFFYUVDSP) += huffyuvdsp.o
diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c
index cb6be0594b4..2a03ebf928c 100644
--- a/libavcodec/h2645_sei.c
+++ b/libavcodec/h2645_sei.c
@@ -208,6 +208,24 @@ static int decode_registered_user_data(H2645SEI *h, GetByteContext *gb,
}
break;
}
+ case 0x5890: { // aom_provider_code
+ const uint16_t aom_grain_provider_oriented_code = 0x0001;
+ uint16_t provider_oriented_code;
+
+ if (!IS_HEVC(codec_id))
+ goto unsupported_provider_code;
+
+ if (bytestream2_get_bytes_left(gb) < 2)
+ return AVERROR_INVALIDDATA;
+
+ provider_oriented_code = bytestream2_get_be16u(gb);
+ if (provider_oriented_code == aom_grain_provider_oriented_code) {
+ return ff_aom_parse_film_grain_sets(&h->aom_film_grain,
+ gb->buffer,
+ bytestream2_get_bytes_left(gb));
+ }
+ break;
+ }
unsupported_provider_code:
#endif
default:
@@ -690,6 +708,25 @@ int ff_h2645_sei_to_frame(AVFrame *frame, H2645SEI *sei,
avctx->properties |= FF_CODEC_PROPERTY_FILM_GRAIN;
}
+#if CONFIG_HEVC_SEI
+ if (sei->aom_film_grain.enable) {
+ const AVFilmGrainAOMParamSet *fgps;
+ fgps = ff_aom_select_film_grain_set(&sei->aom_film_grain, frame);
+ if (fgps && fgps->apply_grain) {
+ AVFilmGrainParams *fgp = av_film_grain_params_create_side_data(frame);
+ if (!fgp)
+ return AVERROR(ENOMEM);
+
+ fgp->type = AV_FILM_GRAIN_PARAMS_AV1;
+ fgp->seed = fgps->grain_seed;
+ fgp->codec.aom = fgps->params;
+
+ if (avctx)
+ avctx->properties |= FF_CODEC_PROPERTY_FILM_GRAIN;
+ }
+ }
+#endif
+
if (sei->ambient_viewing_environment.present) {
H2645SEIAmbientViewingEnvironment *env =
&sei->ambient_viewing_environment;
@@ -779,4 +816,5 @@ void ff_h2645_sei_reset(H2645SEI *s)
s->ambient_viewing_environment.present = 0;
s->mastering_display.present = 0;
s->content_light.present = 0;
+ s->aom_film_grain.enable = 0;
}
diff --git a/libavcodec/h2645_sei.h b/libavcodec/h2645_sei.h
index 0ebf48011af..e5fcfd4e0c2 100644
--- a/libavcodec/h2645_sei.h
+++ b/libavcodec/h2645_sei.h
@@ -23,7 +23,9 @@
#include "libavutil/buffer.h"
#include "libavutil/frame.h"
+#include "libavutil/film_grain_params.h"
+#include "aom_film_grain.h"
#include "avcodec.h"
#include "bytestream.h"
#include "codec_id.h"
@@ -132,6 +134,7 @@ typedef struct H2645SEI {
H2645SEIAmbientViewingEnvironment ambient_viewing_environment;
H2645SEIMasteringDisplay mastering_display;
H2645SEIContentLight content_light;
+ AVFilmGrainAOMParamSets aom_film_grain;
} H2645SEI;
enum {
--
2.43.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-26 14:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 14:35 [FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add AOM film grain synthesis Niklas Haas
2024-02-26 14:35 ` [FFmpeg-devel] [PATCH 2/4] avcodec/aom_film_grain: implement AFGS1 Niklas Haas
2024-02-26 14:35 ` Niklas Haas [this message]
2024-02-26 14:35 ` [FFmpeg-devel] [PATCH 4/4] avcodec/hevcdec: apply AOM film grain synthesis Niklas Haas
2024-02-28 15:45 ` [FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add " Andreas Rheinhardt
2024-02-28 15:56 ` Niklas Haas
2024-02-28 16:01 ` Andreas Rheinhardt
2024-02-29 11:03 ` Niklas Haas
2024-02-29 11:36 ` Andreas Rheinhardt
2024-02-29 12:13 ` Niklas Haas
2024-02-29 11:52 ` Andreas Rheinhardt
2024-02-29 12:18 ` Niklas Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226143521.57913-3-ffmpeg@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=git@haasn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git