Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] Swresample strangeness
Date: Sun, 25 Feb 2024 19:43:50 +0100
Message-ID: <20240225184350.GO6420@pb2> (raw)
In-Reply-To: <6374b936-e240-12fb-ec44-72d60656a893@passwd.hu>


[-- Attachment #1.1: Type: text/plain, Size: 1369 bytes --]

On Sun, Feb 25, 2024 at 05:38:27PM +0100, Marton Balint wrote:
> Hi,
> 
> I am working on a patch to select a better default packet size for the wav
> demuxer, since it reads at most 4096 bytes which can cause insanely small
> packets for files with high channel count.
> 
> Unfortunately some swresample fate tests blew up, and I wonder if the result
> of the resampling should be dependant on size of the audio chunks which are
> being fed to it. My assumption is that if it causes audible difference in
> the output, then it is likely a bug in swresample, but I am not familiar
> with its code and its many tunable variables, so if someone could confirm,
> (or even better, fix it :)) that would be great.

From what you describe, the first thing that comes to mind are timestamps.
If you resample with timestamps that mismatch the exact values expected from
the sample rate. You will have different resuls when the packet size is changed.
Its the same data but at a different point in time and thats different then.

I have too many things to do though so i cant really look into this.

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Take away the freedom of one citizen and you will be jailed, take away
the freedom of all citizens and you will be congratulated by your peers
in Parliament.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-02-25 18:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-25 16:38 Marton Balint
2024-02-25 18:43 ` Michael Niedermayer [this message]
2024-02-26  0:40   ` Marton Balint

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240225184350.GO6420@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git