From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E1319499AD for ; Sun, 25 Feb 2024 01:27:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 09AE368C3D2; Sun, 25 Feb 2024 03:27:35 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 61AA268C046 for ; Sun, 25 Feb 2024 03:27:28 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3E680C0004 for ; Sun, 25 Feb 2024 01:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1708824447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0SIEqhv56ibGLHAb2RJEzOKLfqL23OMKdXqowtTW0sg=; b=JzXosnBN5ykoR2xeWD+HObXIz5NHeiP9FNrnmfRzjUK+YYVumEbTgD5IT3cKVGuSic13xh aXcv3KUMsW1adXpmJuItE94BAEeUn0Au8SxQpE3KaJbPaquGcUSYVoR7SJLbeIElVhSafH OjGi/oG3jzEQYfG3Fg1q5CKFVO92YO/H9Hsv/YTIIsz7PYWHOQZ7dVySenyM1s2vrCztm4 aUDYqjNkXrjsh3O+FqnNOPCORxUJqB5ddsoh+sr/C94Mz60DDDt7OpYMDG7a4/NM7U8375 h8zMFpa0Fsh7/LA8hCsvl7MuNCbq3CZq5b5Qx9OGYVdM9eEfX2dUYK48yIyK4w== Date: Sun, 25 Feb 2024 02:27:26 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240225012726.GN6420@pb2> References: <20240223204105.95953-1-toots@rastageeks.org> MIME-Version: 1.0 In-Reply-To: <20240223204105.95953-1-toots@rastageeks.org> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] Set native order for wav channel layouts up until 8 channels. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3070539966639336451==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3070539966639336451== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VIVOzqUTW7dw4K+F" Content-Disposition: inline --VIVOzqUTW7dw4K+F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 23, 2024 at 02:41:06PM -0600, Romain Beauxis wrote: > The new default channel layout for the various RIFF/WAV decoders is not > backward compatible. >=20 > Historically, most decoders will expect the channel layouts to follow > the native layout up-to a reasonable number of channels. >=20 > Additionally, non-native layouts are causing troubles with filters > chaining. >=20 > This PR changes the default channel layout reported by RIFF/WAV decoders > to default to the native layout when the number of channels is up-to 8. >=20 > The logic for these changes is the same as the logic for the vorbis/opus > decoders. >=20 > Romain breaks fate make -j32 fate-flcl1905 TEST flcl1905 --- ./tests/ref/fate/flcl1905 2024-02-09 03:32:32.540199565 +0100 +++ tests/data/fate/flcl1905 2024-02-25 02:26:51.079111678 +0100 @@ -1,192 +1,192 @@ packet|codec_type=3Daudio|stream_index=3D0|pts=3D0|pts_time=3D0.000000|dts= =3D0|dts_time=3D0.000000|duration=3D22528|duration_time=3D0.510839|size=3D4= 092|pos=3D56|flags=3DK__ -frame|media_type=3Daudio|stream_index=3D0|key_frame=3D1|pts=3DN/A|pts_time= =3DN/A|pkt_dts=3DN/A|pkt_dts_time=3DN/A|best_effort_timestamp=3DN/A|best_ef= fort_timestamp_time=3DN/A|pkt_duration=3D22528|pkt_duration_time=3D0.510839= |duration=3D22528|duration_time=3D0.510839|pkt_pos=3D56|pkt_size=3D4092|sam= ple_fmt=3Dfltp|nb_samples=3D2048|channels=3D2|channel_layout=3Dunknown -frame|media_type=3Daudio|stream_index=3D0|key_frame=3D1|pts=3DN/A|pts_time= =3DN/A|pkt_dts=3DN/A|pkt_dts_time=3DN/A|best_effort_timestamp=3DN/A|best_ef= fort_timestamp_time=3DN/A|pkt_duration=3D22528|pkt_duration_time=3D0.510839= |duration=3D22528|duration_time=3D0.510839|pkt_pos=3D56|pkt_size=3D4092|sam= ple_fmt=3Dfltp|nb_samples=3D2048|channels=3D2|channel_layout=3Dunknown -frame|media_type=3Daudio|stream_index=3D0|key_frame=3D1|pts=3DN/A|pts_time= =3DN/A|pkt_dts=3DN/A|pkt_dts_time=3DN/A|best_effort_timestamp=3DN/A|best_ef= fort_timestamp_time=3DN/A|pkt_duration=3D22528|pkt_duration_time=3D0.510839= |duration=3D22528|duration_time=3D0.510839|pkt_pos=3D56|pkt_size=3D4092|sam= ple_fmt=3Dfltp|nb_samples=3D2048|channels=3D2|channel_layout=3Dunknown =2E.. [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew .= =2E." --VIVOzqUTW7dw4K+F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZdqXdwAKCRBhHseHBAsP q/8kAJ0UDMNbsAyumG8m3Z5Y6ZOthXFTyQCfT7V1LYjSIF6wCOQxf6LEB/5rKG4= =0S5B -----END PGP SIGNATURE----- --VIVOzqUTW7dw4K+F-- --===============3070539966639336451== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3070539966639336451==--