From: "J. Dekker" <jdek@itanimul.li>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v2 2/3] avcodec/x86: disable hevc 12b luma deblock
Date: Thu, 22 Feb 2024 12:38:16 +0100
Message-ID: <20240222113817.51750-2-jdek@itanimul.li> (raw)
In-Reply-To: <20240222113817.51750-1-jdek@itanimul.li>
Over/underflow in some cases.
Signed-off-by: J. Dekker <jdek@itanimul.li>
---
libavcodec/x86/hevcdsp_init.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c
index f5bc342cd5..8831ba957a 100644
--- a/libavcodec/x86/hevcdsp_init.c
+++ b/libavcodec/x86/hevcdsp_init.c
@@ -1205,10 +1205,11 @@ void ff_hevc_dsp_init_x86(HEVCDSPContext *c, const int bit_depth)
if (EXTERNAL_SSE2(cpu_flags)) {
c->hevc_v_loop_filter_chroma = ff_hevc_v_loop_filter_chroma_12_sse2;
c->hevc_h_loop_filter_chroma = ff_hevc_h_loop_filter_chroma_12_sse2;
- if (ARCH_X86_64) {
- c->hevc_v_loop_filter_luma = ff_hevc_v_loop_filter_luma_12_sse2;
- c->hevc_h_loop_filter_luma = ff_hevc_h_loop_filter_luma_12_sse2;
- }
+ // FIXME: 12-bit luma deblock over/underflows in some cases
+ // if (ARCH_X86_64) {
+ // c->hevc_v_loop_filter_luma = ff_hevc_v_loop_filter_luma_12_sse2;
+ // c->hevc_h_loop_filter_luma = ff_hevc_h_loop_filter_luma_12_sse2;
+ // }
SAO_BAND_INIT(12, sse2);
SAO_EDGE_INIT(12, sse2);
--
2.43.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-22 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 11:38 [FFmpeg-devel] [PATCH v2 1/3] checkasm/hevc_deblock: add luma and chroma full J. Dekker
2024-02-22 11:38 ` J. Dekker [this message]
2024-02-22 11:38 ` [FFmpeg-devel] [PATCH v2 3/3] avcodec/aarch64: add hevc deblock NEON J. Dekker
2024-02-26 14:29 ` [FFmpeg-devel] [PATCH v2 1/3] checkasm/hevc_deblock: add luma and chroma full J. Dekker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222113817.51750-2-jdek@itanimul.li \
--to=jdek@itanimul.li \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git