[FFmpeg-devel] [GASPP PATCH] Don't mangle .L local labels for ELF targets

[FFmpeg-devel] [GASPP PATCH] Don't mangle .L local labels for ELF targets

[Martin Storsjö]

This fixes building FFmpeg's libavcodec/aarch64/h264idct_neon.S
for a Linux target. (It's not necessary to use gas-preprocessor for
such a target for a very long time, but it can be useful to be able
to test gas-preprocessor there still.)
---
 gas-preprocessor.pl | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index ba75611..2880858 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -738,7 +738,10 @@ sub handle_serialized_line {
     }
 
     # mach-o local symbol names start with L (no dot)
-    $line =~ s/(?<!\w)\.(L\w+)/$1/g;
+    # armasm also can't handle labels that start with a dot.
+    if ($as_type =~ /apple-/ or $as_type eq "armasm") {
+        $line =~ s/(?<!\w)\.(L\w+)/$1/g;
+    }
 
     # recycle the '.func' directive for '.thumb_func'
     if ($thumb and $as_type =~ /^apple-/) {
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [GASPP PATCH] Don't mangle .L local labels for ELF targets

[J. Dekker]

Martin Storsjö <martin@martin.st> writes:
> This fixes building FFmpeg's libavcodec/aarch64/h264idct_neon.S
> for a Linux target. (It's not necessary to use gas-preprocessor for
> such a target for a very long time, but it can be useful to be able
> to test gas-preprocessor there still.)
> ---
>  gas-preprocessor.pl | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
> index ba75611..2880858 100755
> --- a/gas-preprocessor.pl
> +++ b/gas-preprocessor.pl
> @@ -738,7 +738,10 @@ sub handle_serialized_line {
>      }
>  
>      # mach-o local symbol names start with L (no dot)
> -    $line =~ s/(?<!\w)\.(L\w+)/$1/g;
> +    # armasm also can't handle labels that start with a dot.
> +    if ($as_type =~ /apple-/ or $as_type eq "armasm") {
> +        $line =~ s/(?<!\w)\.(L\w+)/$1/g;
> +    }
>  
>      # recycle the '.func' directive for '.thumb_func'
>      if ($thumb and $as_type =~ /^apple-/) {

LGTM.

-- 
jd
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".