[FFmpeg-devel] [PATCH] fate/mxf: fix mxf-probe-j2k on big endian systems

[FFmpeg-devel] [PATCH] fate/mxf: fix mxf-probe-j2k on big endian systems

[Marton Balint]

Jpeg2000 decoder is decoding in native endian, so let's use the same workaround
as in fate-mxf-probe-applehdr10.

Fixes ticket #10868.

Signed-off-by: Marton Balint <cus@passwd.hu>
---
 tests/fate/mxf.mak           | 2 +-
 tests/ref/fate/mxf-probe-j2k | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/fate/mxf.mak b/tests/fate/mxf.mak
index 8430b01d51..3e0e70e28b 100644
--- a/tests/fate/mxf.mak
+++ b/tests/fate/mxf.mak
@@ -29,7 +29,7 @@ fate-mxf-probe-dnxhd: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)"
 
 FATE_MXF_PROBE-$(call DEMDEC, MXF, JPEG2000) += fate-mxf-probe-j2k
 fate-mxf-probe-j2k: SRC = $(TARGET_SAMPLES)/imf/countdown/countdown-small.mxf
-fate-mxf-probe-j2k: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)"
+fate-mxf-probe-j2k: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)" | sed -e "s/rgb48../rgb48/"
 
 FATE_MXF_PROBE-$(call DEMDEC, MXF, DVVIDEO PCM_S16LE) += fate-mxf-probe-dv25
 fate-mxf-probe-dv25: SRC = $(TARGET_SAMPLES)/mxf/Avid-00005.mxf
diff --git a/tests/ref/fate/mxf-probe-j2k b/tests/ref/fate/mxf-probe-j2k
index 149b3ea0b6..517fbb99a3 100644
--- a/tests/ref/fate/mxf-probe-j2k
+++ b/tests/ref/fate/mxf-probe-j2k
@@ -14,7 +14,7 @@ film_grain=0
 has_b_frames=0
 sample_aspect_ratio=1:1
 display_aspect_ratio=16:9
-pix_fmt=rgb48le
+pix_fmt=rgb48
 level=-99
 color_range=unknown
 color_space=unknown
-- 
2.35.3

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fate/mxf: fix mxf-probe-j2k on big endian systems

[Sean McGovern]

Hi Marton,

On Wed, Feb 21, 2024 at 6:34 PM Marton Balint <cus@passwd.hu> wrote:
>
> Jpeg2000 decoder is decoding in native endian, so let's use the same workaround
> as in fate-mxf-probe-applehdr10.
>
> Fixes ticket #10868.
>
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
>  tests/fate/mxf.mak           | 2 +-
>  tests/ref/fate/mxf-probe-j2k | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/fate/mxf.mak b/tests/fate/mxf.mak
> index 8430b01d51..3e0e70e28b 100644
> --- a/tests/fate/mxf.mak
> +++ b/tests/fate/mxf.mak
> @@ -29,7 +29,7 @@ fate-mxf-probe-dnxhd: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)"
>
>  FATE_MXF_PROBE-$(call DEMDEC, MXF, JPEG2000) += fate-mxf-probe-j2k
>  fate-mxf-probe-j2k: SRC = $(TARGET_SAMPLES)/imf/countdown/countdown-small.mxf
> -fate-mxf-probe-j2k: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)"
> +fate-mxf-probe-j2k: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)" | sed -e "s/rgb48../rgb48/"
>
>  FATE_MXF_PROBE-$(call DEMDEC, MXF, DVVIDEO PCM_S16LE) += fate-mxf-probe-dv25
>  fate-mxf-probe-dv25: SRC = $(TARGET_SAMPLES)/mxf/Avid-00005.mxf
> diff --git a/tests/ref/fate/mxf-probe-j2k b/tests/ref/fate/mxf-probe-j2k
> index 149b3ea0b6..517fbb99a3 100644
> --- a/tests/ref/fate/mxf-probe-j2k
> +++ b/tests/ref/fate/mxf-probe-j2k
> @@ -14,7 +14,7 @@ film_grain=0
>  has_b_frames=0
>  sample_aspect_ratio=1:1
>  display_aspect_ratio=16:9
> -pix_fmt=rgb48le
> +pix_fmt=rgb48
>  level=-99
>  color_range=unknown
>  color_space=unknown
> --
> 2.35.3
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Confirming this fixes #10868 for me.

Thanks,
Sean McGovern
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fate/mxf: fix mxf-probe-j2k on big endian systems

[Tomas Härdin]

tor 2024-02-22 klockan 00:34 +0100 skrev Marton Balint:
> Jpeg2000 decoder is decoding in native endian, so let's use the same
> workaround
> as in fate-mxf-probe-applehdr10.
> 
> Fixes ticket #10868.

OK I suppose

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fate/mxf: fix mxf-probe-j2k on big endian systems

[Marton Balint]

On Fri, 23 Feb 2024, Tomas Härdin wrote:

> tor 2024-02-22 klockan 00:34 +0100 skrev Marton Balint:
>> Jpeg2000 decoder is decoding in native endian, so let's use the same
>> workaround
>> as in fate-mxf-probe-applehdr10.
>>
>> Fixes ticket #10868.
>
> OK I suppose

Ok, thanks, will apply.

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".