From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DF3C347811 for ; Wed, 21 Feb 2024 11:34:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A846268D1B0; Wed, 21 Feb 2024 13:34:05 +0200 (EET) Received: from fhigh4-smtp.messagingengine.com (fhigh4-smtp.messagingengine.com [103.168.172.155]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AF1FC68D19B for ; Wed, 21 Feb 2024 13:33:59 +0200 (EET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 638EA11400B0 for ; Wed, 21 Feb 2024 06:33:58 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 21 Feb 2024 06:33:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itanimul.li; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm2; t=1708515238; x=1708601638; bh=8W5M9ElaX4KVU1lnWUQsh kv5nY1Sg5VesuUZc2ulVb8=; b=kNm8kA5bfPIf9kbZBlTA7QLNqa6K2qiFi+mFz 60w8SyBKpclaHikGoTPyqiHA15T/Ime3c7jJwq0UXyYhOTM8UetqvJn9nqOeuKgo iWr5Hsz4SOrmrtQcMa2QUnulbJEy3uD4ElHaHcH55J7OGYY1mdUnSvbUj8teR8Vb bkf0ZueeqjfoZfF6h5P7YQTOWXputgCbxFwTk38uXmTahBRpos1IBI6g9e7Hud4s Ef1+v4dl74vqwaxxytgFk/2J0ZNTBXRSmmZfLITJenmbH+4PqlNyfCeKl6aMWtTs uZo++K+eBWtnxjNvZKKFNoViR+X3t2ovVxc62EmtX4keIMLkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1708515238; x=1708601638; bh=8W5M9ElaX4KVU1lnWUQshkv5nY1S g5VesuUZc2ulVb8=; b=qtzJ9zPuUbLgncIKwGeQl+uZewCJ+j9HH1CWME+PPk5y sKmPYAhtyMhKuDuml8eT3/Yw/iQ4mZFW4t320UQlyjoL1nDMbd1TAwYpVjiVTst1 O21defp0Yf44rjP0vzXEw5uG7yiN5TSTUZ60CM95Pr1UHkGxm74zwnDptLiG+fcy ifL9jrbwHtOrwI0MJcrFQRBQkqMxpio92+b0TOri1ajfxKUOd4d6o2Znql4lRHEq 0KEYgw1XniDnPsZ62N2js4LvGGVm3ocElYOaD5m4n+kporNymA3aCxutuJnVNX14 GnNlG0+1O2BDNDaLpcU16OIssWePWKhKGuOB4oh7Ag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedvgddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecuogfuuhhsphgvtghtffhomhgrihhnucdlgeelmdenuc fjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepfdflrdcuffgvkhhk vghrfdcuoehjuggvkhesihhtrghnihhmuhhlrdhliheqnecuggftrfgrthhtvghrnhepue evieethefgteffgefhkeeutdetudeikeeifffgleeufeetffekieffvdejhfevnecuffho mhgrihhnpehsohhurhgtvghfohhrghgvrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepjhguvghksehithgrnhhimhhulhdrlhhi X-ME-Proxy: Feedback-ID: i84994747:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 21 Feb 2024 06:33:57 -0500 (EST) From: "J. Dekker" To: ffmpeg-devel@ffmpeg.org Date: Wed, 21 Feb 2024 12:33:55 +0100 Message-ID: <20240221113356.203887-1-jdek@itanimul.li> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 1/2] avdevice: deprecate opengl outdev X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Signed-off-by: J. Dekker --- doc/outdevs.texi | 2 +- libavdevice/opengl_enc.c | 11 +++++++++++ libavdevice/version_major.h | 2 ++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/doc/outdevs.texi b/doc/outdevs.texi index f0484bbf8f..941429a8c8 100644 --- a/doc/outdevs.texi +++ b/doc/outdevs.texi @@ -302,7 +302,7 @@ ffmpeg -re -i INPUT -c:v rawvideo -pix_fmt bgra -f fbdev /dev/fb0 See also @url{http://linux-fbdev.sourceforge.net/}, and fbset(1). @section opengl -OpenGL output device. +OpenGL output device. Deprecated and will be removed. To enable this output device you need to configure FFmpeg with @code{--enable-opengl}. diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c index b2ac6eb16a..69de6fad03 100644 --- a/libavdevice/opengl_enc.c +++ b/libavdevice/opengl_enc.c @@ -224,6 +224,8 @@ typedef struct OpenGLContext { int picture_height; ///< Rendered height int window_width; int window_height; + + int warned; } OpenGLContext; static const struct OpenGLFormatDesc { @@ -1060,6 +1062,15 @@ static av_cold int opengl_write_header(AVFormatContext *h) AVStream *st; int ret; + if (!opengl->warned) { + av_log(opengl, AV_LOG_WARNING, + "The opengl output device is deprecated due to being fundamentally incompatible with libavformat API. " + "For monitoring purposes in ffmpeg you can output to a file or use pipes and a video player.\n" + "Example: ffmpeg -i INPUT -f nut -c:v rawvideo - | ffplay -\n" + ); + opengl->warned = 1; + } + if (h->nb_streams != 1 || par->codec_type != AVMEDIA_TYPE_VIDEO || (par->codec_id != AV_CODEC_ID_WRAPPED_AVFRAME && par->codec_id != AV_CODEC_ID_RAWVIDEO)) { diff --git a/libavdevice/version_major.h b/libavdevice/version_major.h index 9f7b79b2ee..da5854ed4c 100644 --- a/libavdevice/version_major.h +++ b/libavdevice/version_major.h @@ -35,5 +35,7 @@ // reminder to remove the bktr device on next major bump #define FF_API_BKTR_DEVICE (LIBAVDEVICE_VERSION_MAJOR < 62) +// reminder to remove the opengl device on next major bump +#define FF_API_OPENGL_DEVICE (LIBAVDEVICE_VERSION_MAJOR < 62) #endif /* AVDEVICE_VERSION_MAJOR_H */ -- 2.43.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".