* [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context
@ 2024-02-20 18:28 Jan Ekström
2024-02-20 18:30 ` James Almer
2024-02-20 18:35 ` llyyr
0 siblings, 2 replies; 5+ messages in thread
From: Jan Ekström @ 2024-02-20 18:28 UTC (permalink / raw)
To: ffmpeg-devel
`colorspace` in avcodec terms means `matrix coefficients`.
---
libavcodec/av1dec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
index 7ffa7821e9..7debc4deda 100644
--- a/libavcodec/av1dec.c
+++ b/libavcodec/av1dec.c
@@ -743,7 +743,7 @@ static int set_context_with_sequence(AVCodecContext *avctx,
avctx->color_range =
seq->color_config.color_range ? AVCOL_RANGE_JPEG : AVCOL_RANGE_MPEG;
avctx->color_primaries = seq->color_config.color_primaries;
- avctx->colorspace = seq->color_config.color_primaries;
+ avctx->colorspace = seq->color_config.matrix_coefficients;
avctx->color_trc = seq->color_config.transfer_characteristics;
switch (seq->color_config.chroma_sample_position) {
--
2.43.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context
2024-02-20 18:28 [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context Jan Ekström
@ 2024-02-20 18:30 ` James Almer
2024-02-20 18:58 ` Jan Ekström
2024-02-20 18:35 ` llyyr
1 sibling, 1 reply; 5+ messages in thread
From: James Almer @ 2024-02-20 18:30 UTC (permalink / raw)
To: ffmpeg-devel
On 2/20/2024 3:28 PM, Jan Ekström wrote:
> `colorspace` in avcodec terms means `matrix coefficients`.
> ---
> libavcodec/av1dec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> index 7ffa7821e9..7debc4deda 100644
> --- a/libavcodec/av1dec.c
> +++ b/libavcodec/av1dec.c
> @@ -743,7 +743,7 @@ static int set_context_with_sequence(AVCodecContext *avctx,
> avctx->color_range =
> seq->color_config.color_range ? AVCOL_RANGE_JPEG : AVCOL_RANGE_MPEG;
> avctx->color_primaries = seq->color_config.color_primaries;
> - avctx->colorspace = seq->color_config.color_primaries;
> + avctx->colorspace = seq->color_config.matrix_coefficients;
> avctx->color_trc = seq->color_config.transfer_characteristics;
>
> switch (seq->color_config.chroma_sample_position) {
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context
2024-02-20 18:30 ` James Almer
@ 2024-02-20 18:58 ` Jan Ekström
2024-02-20 20:55 ` Jan Ekström
0 siblings, 1 reply; 5+ messages in thread
From: Jan Ekström @ 2024-02-20 18:58 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Tue, Feb 20, 2024 at 8:30 PM James Almer <jamrial@gmail.com> wrote:
>
> On 2/20/2024 3:28 PM, Jan Ekström wrote:
> > `colorspace` in avcodec terms means `matrix coefficients`.
> > ---
> > libavcodec/av1dec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> > index 7ffa7821e9..7debc4deda 100644
> > --- a/libavcodec/av1dec.c
> > +++ b/libavcodec/av1dec.c
> > @@ -743,7 +743,7 @@ static int set_context_with_sequence(AVCodecContext *avctx,
> > avctx->color_range =
> > seq->color_config.color_range ? AVCOL_RANGE_JPEG : AVCOL_RANGE_MPEG;
> > avctx->color_primaries = seq->color_config.color_primaries;
> > - avctx->colorspace = seq->color_config.color_primaries;
> > + avctx->colorspace = seq->color_config.matrix_coefficients;
> > avctx->color_trc = seq->color_config.transfer_characteristics;
> >
> > switch (seq->color_config.chroma_sample_position) {
>
> LGTM
Thanks, applied as 37936b09ce316c32c456539afeb748d472088135 on master.
Will attempt to cherry-pick this as far as possible.
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context
2024-02-20 18:58 ` Jan Ekström
@ 2024-02-20 20:55 ` Jan Ekström
0 siblings, 0 replies; 5+ messages in thread
From: Jan Ekström @ 2024-02-20 20:55 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Tue, Feb 20, 2024 at 8:58 PM Jan Ekström <jeebjp@gmail.com> wrote:
>
> On Tue, Feb 20, 2024 at 8:30 PM James Almer <jamrial@gmail.com> wrote:
> >
> > On 2/20/2024 3:28 PM, Jan Ekström wrote:
> > > `colorspace` in avcodec terms means `matrix coefficients`.
> > > ---
> > > libavcodec/av1dec.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> > > index 7ffa7821e9..7debc4deda 100644
> > > --- a/libavcodec/av1dec.c
> > > +++ b/libavcodec/av1dec.c
> > > @@ -743,7 +743,7 @@ static int set_context_with_sequence(AVCodecContext *avctx,
> > > avctx->color_range =
> > > seq->color_config.color_range ? AVCOL_RANGE_JPEG : AVCOL_RANGE_MPEG;
> > > avctx->color_primaries = seq->color_config.color_primaries;
> > > - avctx->colorspace = seq->color_config.color_primaries;
> > > + avctx->colorspace = seq->color_config.matrix_coefficients;
> > > avctx->color_trc = seq->color_config.transfer_characteristics;
> > >
> > > switch (seq->color_config.chroma_sample_position) {
> >
> > LGTM
>
> Thanks, applied as 37936b09ce316c32c456539afeb748d472088135 on master.
>
> Will attempt to cherry-pick this as far as possible.
This fix was cherry-picked to releases 6.1 (a267d4ad4c92), 6.0
(511b84442323), 5.1 (9bf90b126028), 5.0 (6073fff84d0d), 4.4
(5507a4062496), in which libavcodec/av1dec.c exists.
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context
2024-02-20 18:28 [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context Jan Ekström
2024-02-20 18:30 ` James Almer
@ 2024-02-20 18:35 ` llyyr
1 sibling, 0 replies; 5+ messages in thread
From: llyyr @ 2024-02-20 18:35 UTC (permalink / raw)
To: ffmpeg-devel
On 2/20/24 23:58, Jan Ekström wrote:
> `colorspace` in avcodec terms means `matrix coefficients`.
> ---
> libavcodec/av1dec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> index 7ffa7821e9..7debc4deda 100644
> --- a/libavcodec/av1dec.c
> +++ b/libavcodec/av1dec.c
> @@ -743,7 +743,7 @@ static int set_context_with_sequence(AVCodecContext *avctx,
> avctx->color_range =
> seq->color_config.color_range ? AVCOL_RANGE_JPEG : AVCOL_RANGE_MPEG;
> avctx->color_primaries = seq->color_config.color_primaries;
> - avctx->colorspace = seq->color_config.color_primaries;
> + avctx->colorspace = seq->color_config.matrix_coefficients;
> avctx->color_trc = seq->color_config.transfer_characteristics;
>
> switch (seq->color_config.chroma_sample_position) {
LGTM, fixes this* sample not being rendered in ycgco colorspace when
using hwaccel
*: https://github.com/mpv-player/mpv/issues/13521
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-20 20:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-20 18:28 [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context Jan Ekström
2024-02-20 18:30 ` James Almer
2024-02-20 18:58 ` Jan Ekström
2024-02-20 20:55 ` Jan Ekström
2024-02-20 18:35 ` llyyr
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git