* [FFmpeg-devel] [PATCH v1] avfilter/tonemap_vaapi: Remove duplicate format check
@ 2024-02-20 2:32 fei.w.wang-at-intel.com
2024-02-23 5:14 ` Xiang, Haihao
0 siblings, 1 reply; 2+ messages in thread
From: fei.w.wang-at-intel.com @ 2024-02-20 2:32 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: fei.w.wang
From: Fei Wang <fei.w.wang@intel.com>
Supported formats are checked in base function ff_vaapi_vpp_config_output.
Signed-off-by: Fei Wang <fei.w.wang@intel.com>
---
libavfilter/vf_tonemap_vaapi.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/libavfilter/vf_tonemap_vaapi.c b/libavfilter/vf_tonemap_vaapi.c
index 5de7faa8cc..0b767202d2 100644
--- a/libavfilter/vf_tonemap_vaapi.c
+++ b/libavfilter/vf_tonemap_vaapi.c
@@ -331,14 +331,6 @@ static av_cold int tonemap_vaapi_init(AVFilterContext *avctx)
if (ctx->output_format_string) {
vpp_ctx->output_format = av_get_pix_fmt(ctx->output_format_string);
- switch (vpp_ctx->output_format) {
- case AV_PIX_FMT_NV12:
- case AV_PIX_FMT_P010:
- break;
- default:
- av_log(avctx, AV_LOG_ERROR, "Invalid output format.\n");
- return AVERROR(EINVAL);
- }
} else {
vpp_ctx->output_format = AV_PIX_FMT_NV12;
av_log(avctx, AV_LOG_WARNING, "Output format not set, use default format NV12\n");
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH v1] avfilter/tonemap_vaapi: Remove duplicate format check
2024-02-20 2:32 [FFmpeg-devel] [PATCH v1] avfilter/tonemap_vaapi: Remove duplicate format check fei.w.wang-at-intel.com
@ 2024-02-23 5:14 ` Xiang, Haihao
0 siblings, 0 replies; 2+ messages in thread
From: Xiang, Haihao @ 2024-02-23 5:14 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Wang, Fei W
On Di, 2024-02-20 at 10:32 +0800, fei.w.wang-at-intel.com@ffmpeg.org wrote:
> From: Fei Wang <fei.w.wang@intel.com>
>
> Supported formats are checked in base function ff_vaapi_vpp_config_output.
>
> Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> ---
> libavfilter/vf_tonemap_vaapi.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/libavfilter/vf_tonemap_vaapi.c b/libavfilter/vf_tonemap_vaapi.c
> index 5de7faa8cc..0b767202d2 100644
> --- a/libavfilter/vf_tonemap_vaapi.c
> +++ b/libavfilter/vf_tonemap_vaapi.c
> @@ -331,14 +331,6 @@ static av_cold int tonemap_vaapi_init(AVFilterContext
> *avctx)
>
> if (ctx->output_format_string) {
> vpp_ctx->output_format = av_get_pix_fmt(ctx->output_format_string);
> - switch (vpp_ctx->output_format) {
> - case AV_PIX_FMT_NV12:
> - case AV_PIX_FMT_P010:
> - break;
> - default:
> - av_log(avctx, AV_LOG_ERROR, "Invalid output format.\n");
> - return AVERROR(EINVAL);
> - }
> } else {
> vpp_ctx->output_format = AV_PIX_FMT_NV12;
> av_log(avctx, AV_LOG_WARNING, "Output format not set, use default
> format NV12\n");
LGTM, will apply
- Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-23 5:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-20 2:32 [FFmpeg-devel] [PATCH v1] avfilter/tonemap_vaapi: Remove duplicate format check fei.w.wang-at-intel.com
2024-02-23 5:14 ` Xiang, Haihao
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git