From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6EFAF49735 for ; Sun, 18 Feb 2024 19:21:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 35D3468D384; Sun, 18 Feb 2024 21:21:16 +0200 (EET) Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D689668D302 for ; Sun, 18 Feb 2024 21:21:09 +0200 (EET) Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6818aa08a33so35508636d6.0 for ; Sun, 18 Feb 2024 11:21:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708284068; x=1708888868; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tiwgAqRHqjTVIE1jAkn89vo37MYYaMickAEoYVKIMZk=; b=DRClZqasqZVoWIxERopJrbfitLMrF47dU2tjvLK9Zsb4aUihXdxmTr0j4h9c/7jtvH a6joJ+5DU3UedoxFkOaGH2hhWu/qHCCOAxqCEDRsBsbCSnnFc2i5cr0WR+w/RHtj+a6q jcl1s/YoaTcPdRzHszN6HsHs8zmdwDx3OpEv7FAjQ9lBvJX6rpEEPc74FFSdo6X3zsZT UMhcfWjsbYgukBzQiGxaBdh0abB6HBxWmi1dPCQTMMkmsAJmZAquUy3VyE7m030BPouF E4mwRUItUviBb7CD5hmfCMSmVA4VIkI+DP3xJE+DpZlHg6mW9gnYX1bU6HNv76X3qedE S4ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708284068; x=1708888868; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tiwgAqRHqjTVIE1jAkn89vo37MYYaMickAEoYVKIMZk=; b=eI4wJuQbXqSAzoIAt8ExNqY8zW7gAUdSlBrJnndmtqaGId+br1+l3GCsztxHebEcoC BI+Ryvgh1k8w8v0HjPmHYFYuqRQsI39h38FDmcU1ACxZGlazLZawgsspvvaYBJvJ0zrx T3fcukt7TIjF8zDq5PPkd0dm61cTGMt9ohkaxmqfkACRM98x6D9GaiWJQjdERfAgfsVl gmFWJJvIF7k1GbZMeKyyhWjWZo/BjUni6gzjSzS9y6UjG+394bBoKC1ablJdI+VM6hze 6NRemNw68vP6gI4hRQezC4FC5Scmc2z4YXBeNLH2K97epQ2VYeu1ywROKaX0zt7puw2Y aIBQ== X-Gm-Message-State: AOJu0YzcPo1qkF6CTPrNSAlwEZtDQe1ISRZ5idExgZoTj5k/1iYOQaFv Y3rHZkpjEjDeciG47pe3KoT6k2LVpAGqTzsA9o+bA9UTgzclCl70OvnrtTUUf2g= X-Google-Smtp-Source: AGHT+IEt3CINtyrQ++BscxHsrE5zlQUDug5/7m1HoYusxFlDJlIuA6ZPSMAx1rjqzn+YtJfp5RziVg== X-Received: by 2002:a05:6214:4386:b0:68f:361b:123b with SMTP id oh6-20020a056214438600b0068f361b123bmr11386674qvb.15.1708284068204; Sun, 18 Feb 2024 11:21:08 -0800 (PST) Received: from fedora.. (209-6-133-125.s1659.c3-0.bkl-cbr1.sbo-bkl.ma.cable.rcncustomer.com. [209.6.133.125]) by smtp.gmail.com with ESMTPSA id ly6-20020a0562145c0600b0068c8be959a0sm2329622qvb.111.2024.02.18.11.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 11:21:07 -0800 (PST) From: Stone Chen To: ffmpeg-devel@ffmpeg.org Date: Sun, 18 Feb 2024 14:20:38 -0500 Message-ID: <20240218192054.665995-1-chen.stonechen@gmail.com> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 X-Unsent: 1 Subject: [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Stone Chen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: In commit 6c45d34, a line was added that always sets rdiv to 0, overriding any user input. This removes that line allowing user set values for 0rdiv, 1rdiv, 2rdiv, 3rdiv to apply as expected. This fixes ticket #10294. Signed-off-by: Stone Chen --- libavfilter/vf_convolution.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c index bf67f392f6..a00bb2b3c4 100644 --- a/libavfilter/vf_convolution.c +++ b/libavfilter/vf_convolution.c @@ -674,7 +674,6 @@ static int param_init(AVFilterContext *ctx) p = orig = av_strdup(s->matrix_str[i]); if (p) { s->matrix_length[i] = 0; - s->rdiv[i] = 0.f; sum = 0.f; while (s->matrix_length[i] < 49) { -- 2.43.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".